From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30771 invoked by alias); 13 Jun 2007 14:18:02 -0000 Received: (qmail 30760 invoked by uid 22791); 13 Jun 2007 14:18:01 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate1.de.ibm.com (HELO mtagate1.de.ibm.com) (195.212.29.150) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 13 Jun 2007 14:17:59 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate1.de.ibm.com (8.13.8/8.13.8) with ESMTP id l5DEHvuJ060148 for ; Wed, 13 Jun 2007 14:17:57 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l5DEHuSb4096252 for ; Wed, 13 Jun 2007 16:17:56 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l5DEHuFR029311 for ; Wed, 13 Jun 2007 16:17:56 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l5DEHuh6029308; Wed, 13 Jun 2007 16:17:56 +0200 Message-Id: <200706131417.l5DEHuh6029308@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 13 Jun 2007 16:17:56 +0200 Subject: Re: qXfer:spu:read To: drow@false.org (Daniel Jacobowitz) Date: Wed, 13 Jun 2007 14:18:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20070612200257.GA12884@caradoc.them.org> from "Daniel Jacobowitz" at Jun 12, 2007 04:02:57 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00230.txt.bz2 Daniel Jacobowitz wrote: > But there's no qSupported support for these packets - you probably > need to update remote_protocol_features also. Right - that part appears to have gotten lost. Note that the corresponding qSupported support in gdbserver is already there ... Here's the missing part. Tested on spu-elf against gdbserver. OK for mainline? Bye, Ulrich ChangeLog: * remote.c (remote_protocol_features): Add qXfer:spu:read and qXfer:spu:write packet types. diff -urNp gdb-orig/gdb/remote.c gdb-head/gdb/remote.c --- gdb-orig/gdb/remote.c 2007-06-12 16:35:54.000000000 +0200 +++ gdb-head/gdb/remote.c 2007-06-13 15:19:44.375181482 +0200 @@ -2314,6 +2314,10 @@ static struct protocol_feature remote_pr PACKET_qXfer_features }, { "qXfer:memory-map:read", PACKET_DISABLE, remote_supported_packet, PACKET_qXfer_memory_map }, + { "qXfer:spu:read", PACKET_DISABLE, remote_supported_packet, + PACKET_qXfer_spu_read }, + { "qXfer:spu:write", PACKET_DISABLE, remote_supported_packet, + PACKET_qXfer_spu_write }, { "QPassSignals", PACKET_DISABLE, remote_supported_packet, PACKET_QPassSignals }, }; -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com