From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: drow@false.org (Daniel Jacobowitz)
Cc: gdb-patches@sourceware.org
Subject: Re: qXfer:spu:read
Date: Wed, 13 Jun 2007 14:18:00 -0000 [thread overview]
Message-ID: <200706131417.l5DEHuh6029308@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20070612200257.GA12884@caradoc.them.org> from "Daniel Jacobowitz" at Jun 12, 2007 04:02:57 PM
Daniel Jacobowitz wrote:
> But there's no qSupported support for these packets - you probably
> need to update remote_protocol_features also.
Right - that part appears to have gotten lost. Note that the
corresponding qSupported support in gdbserver is already there ...
Here's the missing part. Tested on spu-elf against gdbserver.
OK for mainline?
Bye,
Ulrich
ChangeLog:
* remote.c (remote_protocol_features): Add qXfer:spu:read and
qXfer:spu:write packet types.
diff -urNp gdb-orig/gdb/remote.c gdb-head/gdb/remote.c
--- gdb-orig/gdb/remote.c 2007-06-12 16:35:54.000000000 +0200
+++ gdb-head/gdb/remote.c 2007-06-13 15:19:44.375181482 +0200
@@ -2314,6 +2314,10 @@ static struct protocol_feature remote_pr
PACKET_qXfer_features },
{ "qXfer:memory-map:read", PACKET_DISABLE, remote_supported_packet,
PACKET_qXfer_memory_map },
+ { "qXfer:spu:read", PACKET_DISABLE, remote_supported_packet,
+ PACKET_qXfer_spu_read },
+ { "qXfer:spu:write", PACKET_DISABLE, remote_supported_packet,
+ PACKET_qXfer_spu_write },
{ "QPassSignals", PACKET_DISABLE, remote_supported_packet,
PACKET_QPassSignals },
};
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2007-06-13 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-12 20:02 qXfer:spu:read Daniel Jacobowitz
2007-06-13 14:18 ` Ulrich Weigand [this message]
2007-06-13 14:25 ` qXfer:spu:read Daniel Jacobowitz
2007-06-13 14:36 ` qXfer:spu:read Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706131417.l5DEHuh6029308@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox