Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Steve Ellcey <sje@cup.hp.com>
To: drow@false.org, schwab@suse.de, eliz@gnu.org,
		mark.kettenis@xs4all.nl, gdb-patches@sourceware.org
Subject: Re: Patch for isdigit/isalpha/etc. macro arguments
Date: Tue, 10 Apr 2007 21:16:00 -0000	[thread overview]
Message-ID: <200704102116.OAA21675@hpsje.cup.hp.com> (raw)
In-Reply-To: <20070408141051.GA13486@caradoc.them.org>

Well, this discussion was very interesting but I am not sure it led
anywhere.  If casting to '(int)' is unacceptable, double casting to
'(int) (unsigned char)' is probably even less acceptable so I would like
to check in the following patch that turns off the warnings so I can
build on HPPA HP-UX.

Tested by building on HPPA HP-UX.

OK to checkin?

2007-04-10  Steve Ellcey  <sje@cup.hp.com>

	* configure.ac (build_warnings): Add -Wno-char-subscripts.
	* doc/gdbint.texinfo (warning flags): Add -Wno-char-subscripts.


Index: configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/configure.ac,v
retrieving revision 1.43
diff -u -p -r1.43 configure.ac
--- configure.ac	29 Mar 2007 15:24:28 -0000	1.43
+++ configure.ac	10 Apr 2007 21:08:01 -0000
@@ -1169,7 +1169,7 @@ fi
 # gdb/doc/gdbint.texinfo.
 build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \
 -Wformat-nonliteral -Wno-pointer-sign \
--Wno-unused -Wno-switch"
+-Wno-unused -Wno-switch -Wno-char-subscripts"
 
 AC_ARG_ENABLE(build-warnings,
 [  --enable-build-warnings Enable build-time compiler warnings if gcc is used],
Index: doc/gdbint.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v
retrieving revision 1.258
diff -u -p -r1.258 gdbint.texinfo
--- doc/gdbint.texinfo	10 Apr 2007 11:58:15 -0000	1.258
+++ doc/gdbint.texinfo	10 Apr 2007 21:08:03 -0000
@@ -5638,6 +5638,7 @@ is being used.
 
 @item -Wno-unused
 @itemx -Wno-switch
+@itemx -Wno-char-subscripts
 These are warnings which might be useful for @value{GDBN}, but are
 currently too noisy to enable with @samp{-Werror}.
 


  reply	other threads:[~2007-04-10 21:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-06 22:34 Steve Ellcey
2007-04-06 23:06 ` Mark Kettenis
2007-04-06 23:17   ` Steve Ellcey
2007-04-06 23:36   ` Steve Ellcey
2007-04-06 23:51     ` Mark Kettenis
2007-04-06 23:59       ` Steve Ellcey
2007-04-07  6:18       ` Andreas Schwab
2007-04-07  9:16         ` Eli Zaretskii
2007-04-07  9:26           ` Andreas Schwab
2007-04-07 17:32             ` Eli Zaretskii
2007-04-07 17:55               ` Andreas Schwab
2007-04-08  8:00                 ` Eli Zaretskii
2007-04-08  9:32                   ` Andreas Schwab
2007-04-08 14:11                     ` Daniel Jacobowitz
2007-04-10 21:16                       ` Steve Ellcey [this message]
2007-04-10 21:21                         ` Daniel Jacobowitz
2007-04-10 21:52                           ` DJ Delorie
2007-04-11  3:36                         ` Eli Zaretskii
2007-04-09 12:57                 ` DJ Delorie
2007-04-09 13:20                   ` Andreas Schwab
2007-04-09 13:43                     ` DJ Delorie
2007-04-09 14:17                       ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200704102116.OAA21675@hpsje.cup.hp.com \
    --to=sje@cup.hp.com \
    --cc=drow@false.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox