From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21570 invoked by alias); 10 Apr 2007 21:16:22 -0000 Received: (qmail 21560 invoked by uid 22791); 10 Apr 2007 21:16:21 -0000 X-Spam-Check-By: sourceware.org Received: from palrel12.hp.com (HELO palrel12.hp.com) (156.153.255.237) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 10 Apr 2007 22:16:18 +0100 Received: from smtp2.cup.hp.com (unknown [15.4.32.118]) by palrel12.hp.com (Postfix) with ESMTP id C6ABA34C88; Tue, 10 Apr 2007 14:16:16 -0700 (PDT) Received: from hpsje.cup.hp.com (hpsje.cup.hp.com [16.89.92.85]) by smtp2.cup.hp.com (Postfix) with ESMTP id 3537630D680; Tue, 10 Apr 2007 21:09:12 +0000 (UTC) Received: (from sje@localhost) by hpsje.cup.hp.com (8.9.3 (PHNE_29774)/8.9.3) id OAA21675; Tue, 10 Apr 2007 14:16:16 -0700 (PDT) Date: Tue, 10 Apr 2007 21:16:00 -0000 From: Steve Ellcey Message-Id: <200704102116.OAA21675@hpsje.cup.hp.com> To: drow@false.org, schwab@suse.de, eliz@gnu.org, mark.kettenis@xs4all.nl, gdb-patches@sourceware.org Subject: Re: Patch for isdigit/isalpha/etc. macro arguments In-Reply-To: <20070408141051.GA13486@caradoc.them.org> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00113.txt.bz2 Well, this discussion was very interesting but I am not sure it led anywhere. If casting to '(int)' is unacceptable, double casting to '(int) (unsigned char)' is probably even less acceptable so I would like to check in the following patch that turns off the warnings so I can build on HPPA HP-UX. Tested by building on HPPA HP-UX. OK to checkin? 2007-04-10 Steve Ellcey * configure.ac (build_warnings): Add -Wno-char-subscripts. * doc/gdbint.texinfo (warning flags): Add -Wno-char-subscripts. Index: configure.ac =================================================================== RCS file: /cvs/src/src/gdb/configure.ac,v retrieving revision 1.43 diff -u -p -r1.43 configure.ac --- configure.ac 29 Mar 2007 15:24:28 -0000 1.43 +++ configure.ac 10 Apr 2007 21:08:01 -0000 @@ -1169,7 +1169,7 @@ fi # gdb/doc/gdbint.texinfo. build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wformat-nonliteral -Wno-pointer-sign \ --Wno-unused -Wno-switch" +-Wno-unused -Wno-switch -Wno-char-subscripts" AC_ARG_ENABLE(build-warnings, [ --enable-build-warnings Enable build-time compiler warnings if gcc is used], Index: doc/gdbint.texinfo =================================================================== RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v retrieving revision 1.258 diff -u -p -r1.258 gdbint.texinfo --- doc/gdbint.texinfo 10 Apr 2007 11:58:15 -0000 1.258 +++ doc/gdbint.texinfo 10 Apr 2007 21:08:03 -0000 @@ -5638,6 +5638,7 @@ is being used. @item -Wno-unused @itemx -Wno-switch +@itemx -Wno-char-subscripts These are warnings which might be useful for @value{GDBN}, but are currently too noisy to enable with @samp{-Werror}.