From: Steve Ellcey <sje@cup.hp.com>
To: mark.kettenis@xs4all.nl
Cc: gdb-patches@sourceware.org
Subject: Re: Patch for isdigit/isalpha/etc. macro arguments
Date: Fri, 06 Apr 2007 23:59:00 -0000 [thread overview]
Message-ID: <200704062359.QAA18034@hpsje.cup.hp.com> (raw)
In-Reply-To: <200704062348.l36NmiwC025816@brahms.sibelius.xs4all.nl>
> Bleach! So that's not a viable option. I think it's time to find the
> magic gcc option to turn the warning off. I mean
>
> char *s = "...";
> isalpha(*s);
>
> is perfectly reasonable code and should not result in compiler
> warnings. And I really don't like adding the casts you propose. To
> me, a cast is an indication that something naughty is being done, and
> that certainly isn't the case here.
>
> Mark
That would be -Wno-char-subscripts. I'll look into adding it.
Steve Ellcey
sje@cup.hp.com
next prev parent reply other threads:[~2007-04-06 23:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-06 22:34 Steve Ellcey
2007-04-06 23:06 ` Mark Kettenis
2007-04-06 23:17 ` Steve Ellcey
2007-04-06 23:36 ` Steve Ellcey
2007-04-06 23:51 ` Mark Kettenis
2007-04-06 23:59 ` Steve Ellcey [this message]
2007-04-07 6:18 ` Andreas Schwab
2007-04-07 9:16 ` Eli Zaretskii
2007-04-07 9:26 ` Andreas Schwab
2007-04-07 17:32 ` Eli Zaretskii
2007-04-07 17:55 ` Andreas Schwab
2007-04-08 8:00 ` Eli Zaretskii
2007-04-08 9:32 ` Andreas Schwab
2007-04-08 14:11 ` Daniel Jacobowitz
2007-04-10 21:16 ` Steve Ellcey
2007-04-10 21:21 ` Daniel Jacobowitz
2007-04-10 21:52 ` DJ Delorie
2007-04-11 3:36 ` Eli Zaretskii
2007-04-09 12:57 ` DJ Delorie
2007-04-09 13:20 ` Andreas Schwab
2007-04-09 13:43 ` DJ Delorie
2007-04-09 14:17 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704062359.QAA18034@hpsje.cup.hp.com \
--to=sje@cup.hp.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox