From: Eli Zaretskii <eliz@gnu.org>
To: Andreas Schwab <schwab@suse.de>
Cc: mark.kettenis@xs4all.nl, sje@cup.hp.com, gdb-patches@sourceware.org
Subject: Re: Patch for isdigit/isalpha/etc. macro arguments
Date: Sat, 07 Apr 2007 09:16:00 -0000 [thread overview]
Message-ID: <uslbc35ov.fsf@gnu.org> (raw)
In-Reply-To: <jewt0o7ln8.fsf@sykes.suse.de> (message from Andreas Schwab on Sat, 07 Apr 2007 08:18:19 +0200)
> From: Andreas Schwab <schwab@suse.de>
> Cc: sje@cup.hp.com, gdb-patches@sourceware.org
> Date: Sat, 07 Apr 2007 08:18:19 +0200
>
> > char *s = "...";
> > isalpha(*s);
> >
> > is perfectly reasonable code and should not result in compiler
> > warnings.
>
> This will crash and burn if *s < 0. You really need to cast to unsigned
> char if you want to get defined behaviour.
Isn't that the job of the isalpha implementation?
next prev parent reply other threads:[~2007-04-07 9:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-06 22:34 Steve Ellcey
2007-04-06 23:06 ` Mark Kettenis
2007-04-06 23:17 ` Steve Ellcey
2007-04-06 23:36 ` Steve Ellcey
2007-04-06 23:51 ` Mark Kettenis
2007-04-06 23:59 ` Steve Ellcey
2007-04-07 6:18 ` Andreas Schwab
2007-04-07 9:16 ` Eli Zaretskii [this message]
2007-04-07 9:26 ` Andreas Schwab
2007-04-07 17:32 ` Eli Zaretskii
2007-04-07 17:55 ` Andreas Schwab
2007-04-08 8:00 ` Eli Zaretskii
2007-04-08 9:32 ` Andreas Schwab
2007-04-08 14:11 ` Daniel Jacobowitz
2007-04-10 21:16 ` Steve Ellcey
2007-04-10 21:21 ` Daniel Jacobowitz
2007-04-10 21:52 ` DJ Delorie
2007-04-11 3:36 ` Eli Zaretskii
2007-04-09 12:57 ` DJ Delorie
2007-04-09 13:20 ` Andreas Schwab
2007-04-09 13:43 ` DJ Delorie
2007-04-09 14:17 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uslbc35ov.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=schwab@suse.de \
--cc=sje@cup.hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox