Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: sje@cup.hp.com, gdb-patches@sourceware.org
Subject: Re: Patch for isdigit/isalpha/etc. macro arguments
Date: Sat, 07 Apr 2007 06:18:00 -0000	[thread overview]
Message-ID: <jewt0o7ln8.fsf@sykes.suse.de> (raw)
In-Reply-To: <200704062348.l36NmiwC025816@brahms.sibelius.xs4all.nl> (Mark 	Kettenis's message of "Sat, 7 Apr 2007 01:48:44 +0200 (CEST)")

Mark Kettenis <mark.kettenis@xs4all.nl> writes:

> Bleach!  So that's not a viable option.  I think it's time to find the
> magic gcc option to turn the warning off.  I mean
>
>   char *s = "...";
>   isalpha(*s);
>
> is perfectly reasonable code and should not result in compiler
> warnings.

This will crash and burn if *s < 0.  You really need to cast to unsigned
char if you want to get defined behaviour.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


  parent reply	other threads:[~2007-04-07  6:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-06 22:34 Steve Ellcey
2007-04-06 23:06 ` Mark Kettenis
2007-04-06 23:17   ` Steve Ellcey
2007-04-06 23:36   ` Steve Ellcey
2007-04-06 23:51     ` Mark Kettenis
2007-04-06 23:59       ` Steve Ellcey
2007-04-07  6:18       ` Andreas Schwab [this message]
2007-04-07  9:16         ` Eli Zaretskii
2007-04-07  9:26           ` Andreas Schwab
2007-04-07 17:32             ` Eli Zaretskii
2007-04-07 17:55               ` Andreas Schwab
2007-04-08  8:00                 ` Eli Zaretskii
2007-04-08  9:32                   ` Andreas Schwab
2007-04-08 14:11                     ` Daniel Jacobowitz
2007-04-10 21:16                       ` Steve Ellcey
2007-04-10 21:21                         ` Daniel Jacobowitz
2007-04-10 21:52                           ` DJ Delorie
2007-04-11  3:36                         ` Eli Zaretskii
2007-04-09 12:57                 ` DJ Delorie
2007-04-09 13:20                   ` Andreas Schwab
2007-04-09 13:43                     ` DJ Delorie
2007-04-09 14:17                       ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jewt0o7ln8.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=sje@cup.hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox