Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: DJ Delorie <dj@redhat.com>
To: schwab@suse.de
Cc: gdb-patches@sourceware.org
Subject: Re: Patch for isdigit/isalpha/etc. macro arguments
Date: Mon, 09 Apr 2007 13:43:00 -0000	[thread overview]
Message-ID: <200704091342.l39DgoX1013027@greed.delorie.com> (raw)
In-Reply-To: <jey7l18z1c.fsf@sykes.suse.de> (message from Andreas Schwab on 	Mon, 09 Apr 2007 15:20:31 +0200)


> The value of '\377' is implementation-defined.

Not in the context of fgetc or <ctype.h> (the places where ambiguity
exists), it isn't (emphasis mine):

 "If the end-of-file indicator for the input stream pointed to by
  stream is not set and a next character is present, the fgetc
  function obtains that character as an UNSIGNED CHAR converted to an
  int and advances the associated file position indicator for the
  stream (if defined)."

 "The header <ctype.h> declares several functions useful for
  classifying and mapping characters.  In all cases the argument is an
  int, the value of which shall be representable as an UNSIGNED CHAR
  or shall equal the value of the macro EOF. If the argument has any
  other value, the behavior is undefined.

It is, unfortunately, up to the programmer to deal with other sources
of character data which may be sign extended, and provide the ctype
macros with the input range they're expecting.

In the case of casts from char* strings, the programmer should:

	isalpha((int)(unsigned char)(*s))

Messy, but pedantic.  The cast to int may be optional.


  reply	other threads:[~2007-04-09 13:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-06 22:34 Steve Ellcey
2007-04-06 23:06 ` Mark Kettenis
2007-04-06 23:17   ` Steve Ellcey
2007-04-06 23:36   ` Steve Ellcey
2007-04-06 23:51     ` Mark Kettenis
2007-04-06 23:59       ` Steve Ellcey
2007-04-07  6:18       ` Andreas Schwab
2007-04-07  9:16         ` Eli Zaretskii
2007-04-07  9:26           ` Andreas Schwab
2007-04-07 17:32             ` Eli Zaretskii
2007-04-07 17:55               ` Andreas Schwab
2007-04-08  8:00                 ` Eli Zaretskii
2007-04-08  9:32                   ` Andreas Schwab
2007-04-08 14:11                     ` Daniel Jacobowitz
2007-04-10 21:16                       ` Steve Ellcey
2007-04-10 21:21                         ` Daniel Jacobowitz
2007-04-10 21:52                           ` DJ Delorie
2007-04-11  3:36                         ` Eli Zaretskii
2007-04-09 12:57                 ` DJ Delorie
2007-04-09 13:20                   ` Andreas Schwab
2007-04-09 13:43                     ` DJ Delorie [this message]
2007-04-09 14:17                       ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200704091342.l39DgoX1013027@greed.delorie.com \
    --to=dj@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox