From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14350 invoked by alias); 6 Apr 2007 23:59:48 -0000 Received: (qmail 14340 invoked by uid 22791); 6 Apr 2007 23:59:47 -0000 X-Spam-Check-By: sourceware.org Received: from palrel12.hp.com (HELO palrel12.hp.com) (156.153.255.237) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 07 Apr 2007 00:59:45 +0100 Received: from smtp2.cup.hp.com (unknown [15.4.32.118]) by palrel12.hp.com (Postfix) with ESMTP id 5676A37783; Fri, 6 Apr 2007 16:59:44 -0700 (PDT) Received: from hpsje.cup.hp.com (hpsje.cup.hp.com [16.89.92.85]) by smtp2.cup.hp.com (Postfix) with ESMTP id 081DD30BE0A; Fri, 6 Apr 2007 23:52:48 +0000 (UTC) Received: (from sje@localhost) by hpsje.cup.hp.com (8.9.3 (PHNE_29774)/8.9.3) id QAA18034; Fri, 6 Apr 2007 16:59:44 -0700 (PDT) Date: Fri, 06 Apr 2007 23:59:00 -0000 From: Steve Ellcey Message-Id: <200704062359.QAA18034@hpsje.cup.hp.com> To: mark.kettenis@xs4all.nl Cc: gdb-patches@sourceware.org Subject: Re: Patch for isdigit/isalpha/etc. macro arguments In-Reply-To: <200704062348.l36NmiwC025816@brahms.sibelius.xs4all.nl> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00039.txt.bz2 > Bleach! So that's not a viable option. I think it's time to find the > magic gcc option to turn the warning off. I mean > > char *s = "..."; > isalpha(*s); > > is perfectly reasonable code and should not result in compiler > warnings. And I really don't like adding the casts you propose. To > me, a cast is an indication that something naughty is being done, and > that certainly isn't the case here. > > Mark That would be -Wno-char-subscripts. I'll look into adding it. Steve Ellcey sje@cup.hp.com