Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] Don't give spurious warnings when using thread specific breakpoints
Date: Wed, 18 Oct 2006 14:14:00 -0000	[thread overview]
Message-ID: <20061018141419.GA7771@nevyn.them.org> (raw)
In-Reply-To: <45361793.1020202@st.com>

On Wed, Oct 18, 2006 at 01:01:23PM +0100, Andrew STUBBS wrote:
> How about the attached patch which includes the one without the other? 
> I've also taken the opportunity to add _() macros to a few strings.

Except that they're not useful that way :-(  This should always be a
red flag:

> -			       : ((others == 1) ? " and" : ""));
> +			       : ((others == 1) ? _(" and") : ""));

There's no useful translation for " and".  If you can't group the
translatable bits into whole messages, you're pretty much stuck.
Maybe Eli will have a suggestion on how to properly mark up this.

Aside from the i18n issues, this patch looks reasonable to me.


-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-10-18 14:14 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-11 13:44 Andrew STUBBS
2006-10-11 13:55 ` Daniel Jacobowitz
2006-10-11 14:46   ` Andrew STUBBS
2006-10-11 20:45     ` Daniel Jacobowitz
2006-10-11 22:12       ` Mark Kettenis
2006-10-11 22:14       ` Joel Brobecker
2006-10-18 12:01       ` Andrew STUBBS
2006-10-18 14:14         ` Daniel Jacobowitz [this message]
2006-10-18 15:12           ` Andrew STUBBS
2006-10-18 19:47             ` Eli Zaretskii
2006-10-18 20:21               ` Andreas Schwab
2006-10-19  4:17                 ` Eli Zaretskii
2006-10-19  9:47               ` Andrew STUBBS
2006-10-20  6:10                 ` Eli Zaretskii
2006-10-20 14:29                   ` Daniel Jacobowitz
2006-10-20 17:42                     ` Eli Zaretskii
2006-10-20 17:47                       ` Daniel Jacobowitz
2006-10-20 18:03                         ` Eli Zaretskii
2006-10-20 18:07                           ` Daniel Jacobowitz
2006-10-20 18:11                             ` Eli Zaretskii
2006-10-19 13:28             ` Daniel Jacobowitz
2006-10-19 15:59               ` Andrew STUBBS
2006-10-18 19:22           ` Eli Zaretskii
2006-10-11 22:06   ` Mark Kettenis
2006-10-12 10:45     ` Andrew STUBBS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061018141419.GA7771@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox