From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11934 invoked by alias); 18 Oct 2006 14:14:26 -0000 Received: (qmail 11926 invoked by uid 22791); 18 Oct 2006 14:14:26 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 18 Oct 2006 14:14:20 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1GaCBX-00024B-7r for gdb-patches@sourceware.org; Wed, 18 Oct 2006 10:14:19 -0400 Date: Wed, 18 Oct 2006 14:14:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [PATCH] Don't give spurious warnings when using thread specific breakpoints Message-ID: <20061018141419.GA7771@nevyn.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <452CF534.4060209@st.com> <20061011135545.GA26060@nevyn.them.org> <452D0385.6010103@st.com> <20061011204525.GA9622@nevyn.them.org> <45361793.1020202@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45361793.1020202@st.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00214.txt.bz2 On Wed, Oct 18, 2006 at 01:01:23PM +0100, Andrew STUBBS wrote: > How about the attached patch which includes the one without the other? > I've also taken the opportunity to add _() macros to a few strings. Except that they're not useful that way :-( This should always be a red flag: > - : ((others == 1) ? " and" : "")); > + : ((others == 1) ? _(" and") : "")); There's no useful translation for " and". If you can't group the translatable bits into whole messages, you're pretty much stuck. Maybe Eli will have a suggestion on how to properly mark up this. Aside from the i18n issues, this patch looks reasonable to me. -- Daniel Jacobowitz CodeSourcery