Re: PATCH: Start Fortran support for variable objects.

[Daniel Jacobowitz <drow@false.org>]

On Sun, Mar 26, 2006 at 10:14:29PM +1200, Nick Roberts wrote:
> How long is overlong?  The longest two lines are 79 and 78 characters (heck, I
> could even fit them on a punched card!).  I think their appearance gets
> slightly screwed up in the patch because they have tabs in them.

Hmm - confusion on my part - but on yours too it seems?

My rule for "too long" is "open emacs in an eighty-column terminal, and
if it wraps them, they're too long".  The one in c_value_of_child just
fits, but the one in c_name_of_child has one too many - emacs
starts at column 0, not column 1, so a semicolon in column 79 means
that emacs will push the semicolon onto the next line (to have room for
the continuation backslash and a space after the cursor).

> FAIL: gdb.mi/mi-file.exp: Getting a list of source files.
> FAIL: gdb.mi/mi-basics.exp: environment-directory arg operation
> FAIL: gdb.mi/mi-basics.exp: environment-directory empty-string operation
> FAIL: gdb.mi/mi-basics.exp: environment-path dir1 dir2 operation
> FAIL: gdb.mi/mi2-basics.exp: environment-directory arg operation
> FAIL: gdb.mi/mi2-basics.exp: environment-directory empty-string operation
> FAIL: gdb.mi/mi2-basics.exp: environment-path dir1 dir2 operation
> 
> 
> I'm pretty sure the fails have always been there for me.

IIRC the mi-basics failures come from configuring GDB using a relative
path.  I don't know the mi-file.exp failure offhand.  But, anyway, this
is plenty good.

It's not hard to do this twice, though, so that you know you have no
new failures - once with the patch and once without.

> 2006-03-26  Nick Roberts  <nickrob@snap.net.nz>
> 
> 	* gdb.mi/mi-var-child-f.exp, gdb.mi/array.f: New files.

Patch is OK with one line wrapped, testcase is OK, thanks a lot!

-- 
Daniel Jacobowitz
CodeSourcery