Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: Start Fortran support for variable objects.
Date: Mon, 27 Mar 2006 04:24:00 -0000	[thread overview]
Message-ID: <17447.13022.354906.331708@kahikatea.snap.net.nz> (raw)
In-Reply-To: <20060326222147.GA8577@nevyn.them.org>

 > My rule for "too long" is "open emacs in an eighty-column terminal, and
 > if it wraps them, they're too long".  The one in c_value_of_child just
 > fits, but the one in c_name_of_child has one too many - emacs
 > starts at column 0, not column 1, 

You're right the lines were 79 and 80 cols wide.

 >                                        so a semicolon in column 79 means
 > that emacs will push the semicolon onto the next line (to have room for
 > the continuation backslash and a space after the cursor).

Not on Emacs 22: the cursor gets pushed into the fringe - anyway I've wrapped
the line, not wishing to appear a sore loser.

 > > FAIL: gdb.mi/mi-file.exp: Getting a list of source files.
 > > FAIL: gdb.mi/mi-basics.exp: environment-directory arg operation
 > > FAIL: gdb.mi/mi-basics.exp: environment-directory empty-string operation
 > > FAIL: gdb.mi/mi-basics.exp: environment-path dir1 dir2 operation
 > > FAIL: gdb.mi/mi2-basics.exp: environment-directory arg operation
 > > FAIL: gdb.mi/mi2-basics.exp: environment-directory empty-string operation
 > > FAIL: gdb.mi/mi2-basics.exp: environment-path dir1 dir2 operation
 > > 
 > > 
 > > I'm pretty sure the fails have always been there for me.
 > 
 > IIRC the mi-basics failures come from configuring GDB using a relative
 > path.  I don't know the mi-file.exp failure offhand.  But, anyway, this
 > is plenty good.
 > 
 > It's not hard to do this twice, though, so that you know you have no
 > new failures - once with the patch and once without.

OK, I'll remember that.

 > > 2006-03-26  Nick Roberts  <nickrob@snap.net.nz>
 > > 
 > > 	* gdb.mi/mi-var-child-f.exp, gdb.mi/array.f: New files.
 > 
 > Patch is OK with one line wrapped, testcase is OK, thanks a lot!

Comitted.

Nick                                           http://www.inet.net.nz/~nickrob


  reply	other threads:[~2006-03-27  0:35 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-29 21:28 Nick Roberts
2005-06-30  2:53 ` Daniel Jacobowitz
2005-06-30  9:28   ` Nick Roberts
2005-06-30 13:15     ` Daniel Jacobowitz
2005-06-30 22:21       ` Nick Roberts
2005-06-30 22:23         ` Daniel Jacobowitz
2005-06-30 13:18 ` Daniel Jacobowitz
2005-06-30 22:21   ` Nick Roberts
2005-07-01  3:35     ` Wu Zhou
2005-07-01  5:04       ` Nick Roberts
2005-07-01 12:00         ` Wu Zhou
2005-07-03 16:17         ` Daniel Jacobowitz
2005-07-03 23:40           ` Nick Roberts
2005-07-03 23:47             ` Daniel Jacobowitz
2005-07-04  1:42               ` Nick Roberts
2005-07-04  3:49                 ` Daniel Jacobowitz
2005-07-04  7:35                   ` Nick Roberts
2005-07-05  3:43                   ` Nick Roberts
2006-03-13 14:08                   ` Nick Roberts
2006-03-24 22:58                     ` Daniel Jacobowitz
2006-03-27  1:25                       ` Nick Roberts
2006-03-27  4:04                         ` Daniel Jacobowitz
2006-03-27  4:24                           ` Nick Roberts [this message]
2006-03-27 11:32                             ` Daniel Jacobowitz
2005-07-06  8:31           ` Wu Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17447.13022.354906.331708@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox