From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5056 invoked by alias); 27 Mar 2006 00:35:29 -0000 Received: (qmail 5047 invoked by uid 22791); 27 Mar 2006 00:35:28 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 27 Mar 2006 00:35:26 +0000 Received: from kahikatea.snap.net.nz (p202-124-114-95.snap.net.nz [202.124.114.95]) by viper.snap.net.nz (Postfix) with ESMTP id 8DB6C74C8EB; Mon, 27 Mar 2006 12:35:08 +1200 (NZST) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 8DF8388FB; Mon, 27 Mar 2006 12:33:35 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17447.13022.354906.331708@kahikatea.snap.net.nz> Date: Mon, 27 Mar 2006 04:24:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: Start Fortran support for variable objects. In-Reply-To: <20060326222147.GA8577@nevyn.them.org> References: <17092.51062.559020.560618@farnswood.snap.net.nz> <20050703161706.GA13289@nevyn.them.org> <17096.30621.21570.307217@farnswood.snap.net.nz> <20050703234725.GA28151@nevyn.them.org> <17096.37817.638887.840041@farnswood.snap.net.nz> <20050704034904.GA5802@nevyn.them.org> <17428.64494.595245.325277@kahikatea.snap.net.nz> <20060324210718.GD26748@nevyn.them.org> <17446.27013.68291.439386@kahikatea.snap.net.nz> <20060326222147.GA8577@nevyn.them.org> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00304.txt.bz2 > My rule for "too long" is "open emacs in an eighty-column terminal, and > if it wraps them, they're too long". The one in c_value_of_child just > fits, but the one in c_name_of_child has one too many - emacs > starts at column 0, not column 1, You're right the lines were 79 and 80 cols wide. > so a semicolon in column 79 means > that emacs will push the semicolon onto the next line (to have room for > the continuation backslash and a space after the cursor). Not on Emacs 22: the cursor gets pushed into the fringe - anyway I've wrapped the line, not wishing to appear a sore loser. > > FAIL: gdb.mi/mi-file.exp: Getting a list of source files. > > FAIL: gdb.mi/mi-basics.exp: environment-directory arg operation > > FAIL: gdb.mi/mi-basics.exp: environment-directory empty-string operation > > FAIL: gdb.mi/mi-basics.exp: environment-path dir1 dir2 operation > > FAIL: gdb.mi/mi2-basics.exp: environment-directory arg operation > > FAIL: gdb.mi/mi2-basics.exp: environment-directory empty-string operation > > FAIL: gdb.mi/mi2-basics.exp: environment-path dir1 dir2 operation > > > > > > I'm pretty sure the fails have always been there for me. > > IIRC the mi-basics failures come from configuring GDB using a relative > path. I don't know the mi-file.exp failure offhand. But, anyway, this > is plenty good. > > It's not hard to do this twice, though, so that you know you have no > new failures - once with the patch and once without. OK, I'll remember that. > > 2006-03-26 Nick Roberts > > > > * gdb.mi/mi-var-child-f.exp, gdb.mi/array.f: New files. > > Patch is OK with one line wrapped, testcase is OK, thanks a lot! Comitted. Nick http://www.inet.net.nz/~nickrob