Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Wu Zhou <woodzltc@cn.ibm.com>, gdb-patches@sources.redhat.com
Subject: Re: PATCH: Start Fortran support for variable objects.
Date: Fri, 24 Mar 2006 22:58:00 -0000	[thread overview]
Message-ID: <20060324210718.GD26748@nevyn.them.org> (raw)
In-Reply-To: <17428.64494.595245.325277@kahikatea.snap.net.nz>

On Mon, Mar 13, 2006 at 05:58:22PM +1300, Nick Roberts wrote:
> Here's a new patch which does the same as my last one.  So the children map as
> before i.e arr.1 == arr(1) because the index for expression "exp" is used to
> compute the "name".  However this time I've made changes to c_name_of_child
> and c_value_of_child instead of varobj_list_children, so hopefully you'll find
> it more agreeable.
> 
> If I don't change c_name_of_child, I get variable object names like arr.0 as
> you suggest. However, then I also get exp="0" which I use for the index of the
> watch expression.  I think this is confusing.

Yeah.  If I understand correctly, this patch will name the first
element of the array as var.-1 - is that right?

I think that's OK.  However, please add a gdb.mi testcase, and use
temporary variables or wrapping where necessary to avoid the overlong
lines; you added two.  If the testcase is a problem let me know and
I'll take care of it.

Thanks for seeing this through!

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-03-24 21:07 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-29 21:28 Nick Roberts
2005-06-30  2:53 ` Daniel Jacobowitz
2005-06-30  9:28   ` Nick Roberts
2005-06-30 13:15     ` Daniel Jacobowitz
2005-06-30 22:21       ` Nick Roberts
2005-06-30 22:23         ` Daniel Jacobowitz
2005-06-30 13:18 ` Daniel Jacobowitz
2005-06-30 22:21   ` Nick Roberts
2005-07-01  3:35     ` Wu Zhou
2005-07-01  5:04       ` Nick Roberts
2005-07-01 12:00         ` Wu Zhou
2005-07-03 16:17         ` Daniel Jacobowitz
2005-07-03 23:40           ` Nick Roberts
2005-07-03 23:47             ` Daniel Jacobowitz
2005-07-04  1:42               ` Nick Roberts
2005-07-04  3:49                 ` Daniel Jacobowitz
2005-07-04  7:35                   ` Nick Roberts
2005-07-05  3:43                   ` Nick Roberts
2006-03-13 14:08                   ` Nick Roberts
2006-03-24 22:58                     ` Daniel Jacobowitz [this message]
2006-03-27  1:25                       ` Nick Roberts
2006-03-27  4:04                         ` Daniel Jacobowitz
2006-03-27  4:24                           ` Nick Roberts
2006-03-27 11:32                             ` Daniel Jacobowitz
2005-07-06  8:31           ` Wu Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060324210718.GD26748@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=nickrob@snap.net.nz \
    --cc=woodzltc@cn.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox