Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Daniel Jacobowitz <drow@false.org>
Cc: Wu Zhou <woodzltc@cn.ibm.com>, gdb-patches@sources.redhat.com
Subject: Re: PATCH: Start Fortran support for variable objects.
Date: Sun, 03 Jul 2005 23:40:00 -0000	[thread overview]
Message-ID: <17096.30621.21570.307217@farnswood.snap.net.nz> (raw)
In-Reply-To: <20050703161706.GA13289@nevyn.them.org>

Daniel Jacobowitz writes:
 > On Fri, Jul 01, 2005 at 04:32:54PM +1200, Nick Roberts wrote:
 > > So I should have done:
 > > 
 > > (top-gdb) p TYPE_LOW_BOUND(var->type->main_type->fields->type)
 > > $1 = 1
 > > (top-gdb) p TYPE_HIGH_BOUND(var->type->main_type->fields->type)
 > > $2 = 4
 > 
 > Right - specifically, TYPE_LOW_BOUND (TYPE_INDEX_TYPE (var->type))
 > is supposed to be the lower bound for an array.  Tricky.  It comes from
 > read_subrange_type in dwarf2read.c for dwarf2.

Or even TYPE_ARRAY_LOWER_BOUND_VALUE (var->type)?

Presumably these macros are more general than dwarf2.  I don't understand the
connection with read_subrange_type.

 ...
 > First of all, never reference ->main_type - see above for the right way
 > to get the low bound.  An even better way (it seems) is to call
 > get_discrete_bounds.  Take a look at value_subscript for an example.

Better than TYPE_LOW_BOUND?

 ...
 > So let's use TYPE_LOW_BOUND for now; does that eliminate the need for
 > the fortran-specific code?

OK.  And, in future, bear get_discrete_bounds in mind?

Nick


  reply	other threads:[~2005-07-03 23:40 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-29 21:28 Nick Roberts
2005-06-30  2:53 ` Daniel Jacobowitz
2005-06-30  9:28   ` Nick Roberts
2005-06-30 13:15     ` Daniel Jacobowitz
2005-06-30 22:21       ` Nick Roberts
2005-06-30 22:23         ` Daniel Jacobowitz
2005-06-30 13:18 ` Daniel Jacobowitz
2005-06-30 22:21   ` Nick Roberts
2005-07-01  3:35     ` Wu Zhou
2005-07-01  5:04       ` Nick Roberts
2005-07-01 12:00         ` Wu Zhou
2005-07-03 16:17         ` Daniel Jacobowitz
2005-07-03 23:40           ` Nick Roberts [this message]
2005-07-03 23:47             ` Daniel Jacobowitz
2005-07-04  1:42               ` Nick Roberts
2005-07-04  3:49                 ` Daniel Jacobowitz
2005-07-04  7:35                   ` Nick Roberts
2005-07-05  3:43                   ` Nick Roberts
2006-03-13 14:08                   ` Nick Roberts
2006-03-24 22:58                     ` Daniel Jacobowitz
2006-03-27  1:25                       ` Nick Roberts
2006-03-27  4:04                         ` Daniel Jacobowitz
2006-03-27  4:24                           ` Nick Roberts
2006-03-27 11:32                             ` Daniel Jacobowitz
2005-07-06  8:31           ` Wu Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17096.30621.21570.307217@farnswood.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=woodzltc@cn.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox