Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: Start Fortran support for variable objects.
Date: Thu, 30 Jun 2005 13:18:00 -0000	[thread overview]
Message-ID: <20050630131809.GB8241@nevyn.them.org> (raw)
In-Reply-To: <17091.4780.953681.620094@farnswood.snap.net.nz>

On Thu, Jun 30, 2005 at 09:29:16AM +1200, Nick Roberts wrote:
> !     vlang_unknown = 0, vlang_c, vlang_cplus, vlang_java,  vlang_fortran,
> !     vlang_end

Extra space before vlang_fortran.

>      java_value_of_variable}
> +   ,
> +   /* Fortran */

This style's wacky, but it's already in the file, so that's fine.

> --- 727,742 ----
>         /* Mark as the end in case we bail out */
>         *((*childlist) + i) = NULL;
>   
> +       if (variable_language (var) == vlang_fortran)
> + 	j = i + 1;
> +       else
> + 	j = i;
> + 
>         /* check if child exists, if not create */
> !       name = name_of_child (var, j);
>         child = child_exists (var, name);
>         if (child == NULL)
> ! 	child = create_child (var, j, name);
>   
>         *((*childlist) + i) = child;
>       }

Do you think you should use f77_get_dynamic_lowerbound?  See eval.c,
under multi_f77_subscript.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


  parent reply	other threads:[~2005-06-30 13:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-29 21:28 Nick Roberts
2005-06-30  2:53 ` Daniel Jacobowitz
2005-06-30  9:28   ` Nick Roberts
2005-06-30 13:15     ` Daniel Jacobowitz
2005-06-30 22:21       ` Nick Roberts
2005-06-30 22:23         ` Daniel Jacobowitz
2005-06-30 13:18 ` Daniel Jacobowitz [this message]
2005-06-30 22:21   ` Nick Roberts
2005-07-01  3:35     ` Wu Zhou
2005-07-01  5:04       ` Nick Roberts
2005-07-01 12:00         ` Wu Zhou
2005-07-03 16:17         ` Daniel Jacobowitz
2005-07-03 23:40           ` Nick Roberts
2005-07-03 23:47             ` Daniel Jacobowitz
2005-07-04  1:42               ` Nick Roberts
2005-07-04  3:49                 ` Daniel Jacobowitz
2005-07-04  7:35                   ` Nick Roberts
2005-07-05  3:43                   ` Nick Roberts
2006-03-13 14:08                   ` Nick Roberts
2006-03-24 22:58                     ` Daniel Jacobowitz
2006-03-27  1:25                       ` Nick Roberts
2006-03-27  4:04                         ` Daniel Jacobowitz
2006-03-27  4:24                           ` Nick Roberts
2006-03-27 11:32                             ` Daniel Jacobowitz
2005-07-06  8:31           ` Wu Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050630131809.GB8241@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox