From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9702 invoked by alias); 30 Jun 2005 13:18:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9642 invoked by uid 22791); 30 Jun 2005 13:18:10 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 30 Jun 2005 13:18:10 +0000 Received: from drow by nevyn.them.org with local (Exim 4.51) id 1Dnyvh-0002Gg-1P; Thu, 30 Jun 2005 09:18:09 -0400 Date: Thu, 30 Jun 2005 13:18:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: Start Fortran support for variable objects. Message-ID: <20050630131809.GB8241@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <17091.4780.953681.620094@farnswood.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17091.4780.953681.620094@farnswood.snap.net.nz> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-06/txt/msg00389.txt.bz2 On Thu, Jun 30, 2005 at 09:29:16AM +1200, Nick Roberts wrote: > ! vlang_unknown = 0, vlang_c, vlang_cplus, vlang_java, vlang_fortran, > ! vlang_end Extra space before vlang_fortran. > java_value_of_variable} > + , > + /* Fortran */ This style's wacky, but it's already in the file, so that's fine. > --- 727,742 ---- > /* Mark as the end in case we bail out */ > *((*childlist) + i) = NULL; > > + if (variable_language (var) == vlang_fortran) > + j = i + 1; > + else > + j = i; > + > /* check if child exists, if not create */ > ! name = name_of_child (var, j); > child = child_exists (var, name); > if (child == NULL) > ! child = create_child (var, j, name); > > *((*childlist) + i) = child; > } Do you think you should use f77_get_dynamic_lowerbound? See eval.c, under multi_f77_subscript. -- Daniel Jacobowitz CodeSourcery, LLC