From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2394 invoked by alias); 24 Mar 2006 21:07:24 -0000 Received: (qmail 2385 invoked by uid 22791); 24 Mar 2006 21:07:24 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 24 Mar 2006 21:07:23 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FMtV8-0007QZ-OI; Fri, 24 Mar 2006 16:07:18 -0500 Date: Fri, 24 Mar 2006 22:58:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Wu Zhou , gdb-patches@sources.redhat.com Subject: Re: PATCH: Start Fortran support for variable objects. Message-ID: <20060324210718.GD26748@nevyn.them.org> Mail-Followup-To: Nick Roberts , Wu Zhou , gdb-patches@sources.redhat.com References: <20050630131809.GB8241@nevyn.them.org> <17092.28833.284587.118362@farnswood.snap.net.nz> <17092.51062.559020.560618@farnswood.snap.net.nz> <20050703161706.GA13289@nevyn.them.org> <17096.30621.21570.307217@farnswood.snap.net.nz> <20050703234725.GA28151@nevyn.them.org> <17096.37817.638887.840041@farnswood.snap.net.nz> <20050704034904.GA5802@nevyn.them.org> <17428.64494.595245.325277@kahikatea.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17428.64494.595245.325277@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00277.txt.bz2 On Mon, Mar 13, 2006 at 05:58:22PM +1300, Nick Roberts wrote: > Here's a new patch which does the same as my last one. So the children map as > before i.e arr.1 == arr(1) because the index for expression "exp" is used to > compute the "name". However this time I've made changes to c_name_of_child > and c_value_of_child instead of varobj_list_children, so hopefully you'll find > it more agreeable. > > If I don't change c_name_of_child, I get variable object names like arr.0 as > you suggest. However, then I also get exp="0" which I use for the index of the > watch expression. I think this is confusing. Yeah. If I understand correctly, this patch will name the first element of the array as var.-1 - is that right? I think that's OK. However, please add a gdb.mi testcase, and use temporary variables or wrapping where necessary to avoid the overlong lines; you added two. If the testcase is a problem let me know and I'll take care of it. Thanks for seeing this through! -- Daniel Jacobowitz CodeSourcery