From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23859 invoked by alias); 26 Mar 2006 22:22:00 -0000 Received: (qmail 23850 invoked by uid 22791); 26 Mar 2006 22:21:59 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sun, 26 Mar 2006 22:21:58 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FNdcJ-00033H-HU; Sun, 26 Mar 2006 17:21:47 -0500 Date: Mon, 27 Mar 2006 04:04:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Wu Zhou , gdb-patches@sources.redhat.com Subject: Re: PATCH: Start Fortran support for variable objects. Message-ID: <20060326222147.GA8577@nevyn.them.org> Mail-Followup-To: Nick Roberts , Wu Zhou , gdb-patches@sources.redhat.com References: <17092.51062.559020.560618@farnswood.snap.net.nz> <20050703161706.GA13289@nevyn.them.org> <17096.30621.21570.307217@farnswood.snap.net.nz> <20050703234725.GA28151@nevyn.them.org> <17096.37817.638887.840041@farnswood.snap.net.nz> <20050704034904.GA5802@nevyn.them.org> <17428.64494.595245.325277@kahikatea.snap.net.nz> <20060324210718.GD26748@nevyn.them.org> <17446.27013.68291.439386@kahikatea.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17446.27013.68291.439386@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00303.txt.bz2 On Sun, Mar 26, 2006 at 10:14:29PM +1200, Nick Roberts wrote: > How long is overlong? The longest two lines are 79 and 78 characters (heck, I > could even fit them on a punched card!). I think their appearance gets > slightly screwed up in the patch because they have tabs in them. Hmm - confusion on my part - but on yours too it seems? My rule for "too long" is "open emacs in an eighty-column terminal, and if it wraps them, they're too long". The one in c_value_of_child just fits, but the one in c_name_of_child has one too many - emacs starts at column 0, not column 1, so a semicolon in column 79 means that emacs will push the semicolon onto the next line (to have room for the continuation backslash and a space after the cursor). > FAIL: gdb.mi/mi-file.exp: Getting a list of source files. > FAIL: gdb.mi/mi-basics.exp: environment-directory arg operation > FAIL: gdb.mi/mi-basics.exp: environment-directory empty-string operation > FAIL: gdb.mi/mi-basics.exp: environment-path dir1 dir2 operation > FAIL: gdb.mi/mi2-basics.exp: environment-directory arg operation > FAIL: gdb.mi/mi2-basics.exp: environment-directory empty-string operation > FAIL: gdb.mi/mi2-basics.exp: environment-path dir1 dir2 operation > > > I'm pretty sure the fails have always been there for me. IIRC the mi-basics failures come from configuring GDB using a relative path. I don't know the mi-file.exp failure offhand. But, anyway, this is plenty good. It's not hard to do this twice, though, so that you know you have no new failures - once with the patch and once without. > 2006-03-26 Nick Roberts > > * gdb.mi/mi-var-child-f.exp, gdb.mi/array.f: New files. Patch is OK with one line wrapped, testcase is OK, thanks a lot! -- Daniel Jacobowitz CodeSourcery