[RFA] fix build failure on ppc-aix

[RFA] fix build failure on ppc-aix

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]

Hello,

GDB stopped building after the fix for PR gdb/1914 was checked in.
It's a tiny copy/paste issue, where a variable used in the call to
the LIB_CREATE_INFERIOR_HOOK is not available in the context where
the code has been moved to.

I think the attached patch provides the appropriate fix. I don't
see any other way to get the pid. I looked at the code, and it
seems to me that inferior_ptid will always be set at that point.
The only case when I wasn't completely sure is in corelow. But
I don't think that the solib code would be affected in that case
if the PID wasn't set. Would it?

2006-01-27  Joel Brobecker  <brobecker@adacore.com>

        * infcmd.c (post_create_inferior): Fix copy/paste error introduced
        in the previous change.

Fixes the build on ppc-aix. I also ran the testsuite out of curiosity.
The results are fair for this platform.

-- 
Joel

[-- Attachment #2: infcmd.c.diff --]
[-- Type: text/plain, Size: 595 bytes --]

Index: infcmd.c
===================================================================
RCS file: /cvs/src/src/gdb/infcmd.c,v
retrieving revision 1.143
diff -u -p -r1.143 infcmd.c
--- infcmd.c	24 Jan 2006 22:34:34 -0000	1.143
+++ infcmd.c	27 Jan 2006 19:16:53 -0000
@@ -419,7 +419,7 @@ post_create_inferior (struct target_ops 
       /* Create the hooks to handle shared library load and unload
 	 events.  */
 #ifdef SOLIB_CREATE_INFERIOR_HOOK
-      SOLIB_CREATE_INFERIOR_HOOK (pid);
+      SOLIB_CREATE_INFERIOR_HOOK (PIDGET (inferior_ptid));
 #else
       solib_create_inferior_hook ();
 #endif

Re: [RFA] fix build failure on ppc-aix

[Daniel Jacobowitz]

On Fri, Jan 27, 2006 at 02:31:32PM -0500, Joel Brobecker wrote:
> Hello,
> 
> GDB stopped building after the fix for PR gdb/1914 was checked in.
> It's a tiny copy/paste issue, where a variable used in the call to
> the LIB_CREATE_INFERIOR_HOOK is not available in the context where
> the code has been moved to.
> 
> I think the attached patch provides the appropriate fix. I don't
> see any other way to get the pid. I looked at the code, and it
> seems to me that inferior_ptid will always be set at that point.
> The only case when I wasn't completely sure is in corelow. But
> I don't think that the solib code would be affected in that case
> if the PID wasn't set. Would it?
> 
> 2006-01-27  Joel Brobecker  <brobecker@adacore.com>
> 
>         * infcmd.c (post_create_inferior): Fix copy/paste error introduced
>         in the previous change.
> 
> Fixes the build on ppc-aix. I also ran the testsuite out of curiosity.
> The results are fair for this platform.

Wow, the xcoff solib code is a mess; I doubt it works right with
corefiles at all, since if this gets called, it's going to do ptrace
ops.  But your patch is fine.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [RFA] fix build failure on ppc-aix

[Joel Brobecker]

> > 2006-01-27  Joel Brobecker  <brobecker@adacore.com>
> > 
> >         * infcmd.c (post_create_inferior): Fix copy/paste error introduced
> >         in the previous change.
> > 
> > Fixes the build on ppc-aix. I also ran the testsuite out of curiosity.
> > The results are fair for this platform.
> 
> Wow, the xcoff solib code is a mess; I doubt it works right with
> corefiles at all, since if this gets called, it's going to do ptrace
> ops.  But your patch is fine.

Sigh.... More stuff for me to add to my list. I'm more interested in
the solaris cleanup that I started discussing with Mark for now, but
will try to remember this too.

I will commit my patch shortly.

Thanks,
-- 
Joel