From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24596 invoked by alias); 27 Jan 2006 19:31:36 -0000 Received: (qmail 24588 invoked by uid 22791); 27 Jan 2006 19:31:35 -0000 X-Spam-Check-By: sourceware.org Received: from nile.gnat.com (HELO nile.gnat.com) (205.232.38.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 27 Jan 2006 19:31:34 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-nile.gnat.com (Postfix) with ESMTP id 7A21E48CDFE for ; Fri, 27 Jan 2006 14:31:32 -0500 (EST) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 25485-01-3 for ; Fri, 27 Jan 2006 14:31:32 -0500 (EST) Received: from takamaka.act-europe.fr (joel.gnat.com [205.232.38.116]) by nile.gnat.com (Postfix) with ESMTP id 468A148CDDE for ; Fri, 27 Jan 2006 14:31:32 -0500 (EST) Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 3572047E7E; Fri, 27 Jan 2006 14:31:32 -0500 (EST) Date: Fri, 27 Jan 2006 19:31:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: [RFA] fix build failure on ppc-aix Message-ID: <20060127193132.GF1203@adacore.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="CblX+4bnyfN0pR09" Content-Disposition: inline User-Agent: Mutt/1.4i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00451.txt.bz2 --CblX+4bnyfN0pR09 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 875 Hello, GDB stopped building after the fix for PR gdb/1914 was checked in. It's a tiny copy/paste issue, where a variable used in the call to the LIB_CREATE_INFERIOR_HOOK is not available in the context where the code has been moved to. I think the attached patch provides the appropriate fix. I don't see any other way to get the pid. I looked at the code, and it seems to me that inferior_ptid will always be set at that point. The only case when I wasn't completely sure is in corelow. But I don't think that the solib code would be affected in that case if the PID wasn't set. Would it? 2006-01-27 Joel Brobecker * infcmd.c (post_create_inferior): Fix copy/paste error introduced in the previous change. Fixes the build on ppc-aix. I also ran the testsuite out of curiosity. The results are fair for this platform. -- Joel --CblX+4bnyfN0pR09 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="infcmd.c.diff" Content-length: 595 Index: infcmd.c =================================================================== RCS file: /cvs/src/src/gdb/infcmd.c,v retrieving revision 1.143 diff -u -p -r1.143 infcmd.c --- infcmd.c 24 Jan 2006 22:34:34 -0000 1.143 +++ infcmd.c 27 Jan 2006 19:16:53 -0000 @@ -419,7 +419,7 @@ post_create_inferior (struct target_ops /* Create the hooks to handle shared library load and unload events. */ #ifdef SOLIB_CREATE_INFERIOR_HOOK - SOLIB_CREATE_INFERIOR_HOOK (pid); + SOLIB_CREATE_INFERIOR_HOOK (PIDGET (inferior_ptid)); #else solib_create_inferior_hook (); #endif --CblX+4bnyfN0pR09--