Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA] fix build failure on ppc-aix
Date: Fri, 27 Jan 2006 19:31:00 -0000	[thread overview]
Message-ID: <20060127193132.GF1203@adacore.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]

Hello,

GDB stopped building after the fix for PR gdb/1914 was checked in.
It's a tiny copy/paste issue, where a variable used in the call to
the LIB_CREATE_INFERIOR_HOOK is not available in the context where
the code has been moved to.

I think the attached patch provides the appropriate fix. I don't
see any other way to get the pid. I looked at the code, and it
seems to me that inferior_ptid will always be set at that point.
The only case when I wasn't completely sure is in corelow. But
I don't think that the solib code would be affected in that case
if the PID wasn't set. Would it?

2006-01-27  Joel Brobecker  <brobecker@adacore.com>

        * infcmd.c (post_create_inferior): Fix copy/paste error introduced
        in the previous change.

Fixes the build on ppc-aix. I also ran the testsuite out of curiosity.
The results are fair for this platform.

-- 
Joel

[-- Attachment #2: infcmd.c.diff --]
[-- Type: text/plain, Size: 595 bytes --]

Index: infcmd.c
===================================================================
RCS file: /cvs/src/src/gdb/infcmd.c,v
retrieving revision 1.143
diff -u -p -r1.143 infcmd.c
--- infcmd.c	24 Jan 2006 22:34:34 -0000	1.143
+++ infcmd.c	27 Jan 2006 19:16:53 -0000
@@ -419,7 +419,7 @@ post_create_inferior (struct target_ops 
       /* Create the hooks to handle shared library load and unload
 	 events.  */
 #ifdef SOLIB_CREATE_INFERIOR_HOOK
-      SOLIB_CREATE_INFERIOR_HOOK (pid);
+      SOLIB_CREATE_INFERIOR_HOOK (PIDGET (inferior_ptid));
 #else
       solib_create_inferior_hook ();
 #endif

             reply	other threads:[~2006-01-27 19:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-27 19:31 Joel Brobecker [this message]
2006-01-27 19:40 ` Daniel Jacobowitz
2006-01-27 20:02   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060127193132.GF1203@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox