From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] fix build failure on ppc-aix
Date: Fri, 27 Jan 2006 19:40:00 -0000 [thread overview]
Message-ID: <20060127194032.GA18246@nevyn.them.org> (raw)
In-Reply-To: <20060127193132.GF1203@adacore.com>
On Fri, Jan 27, 2006 at 02:31:32PM -0500, Joel Brobecker wrote:
> Hello,
>
> GDB stopped building after the fix for PR gdb/1914 was checked in.
> It's a tiny copy/paste issue, where a variable used in the call to
> the LIB_CREATE_INFERIOR_HOOK is not available in the context where
> the code has been moved to.
>
> I think the attached patch provides the appropriate fix. I don't
> see any other way to get the pid. I looked at the code, and it
> seems to me that inferior_ptid will always be set at that point.
> The only case when I wasn't completely sure is in corelow. But
> I don't think that the solib code would be affected in that case
> if the PID wasn't set. Would it?
>
> 2006-01-27 Joel Brobecker <brobecker@adacore.com>
>
> * infcmd.c (post_create_inferior): Fix copy/paste error introduced
> in the previous change.
>
> Fixes the build on ppc-aix. I also ran the testsuite out of curiosity.
> The results are fair for this platform.
Wow, the xcoff solib code is a mess; I doubt it works right with
corefiles at all, since if this gets called, it's going to do ptrace
ops. But your patch is fine.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-01-27 19:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-27 19:31 Joel Brobecker
2006-01-27 19:40 ` Daniel Jacobowitz [this message]
2006-01-27 20:02 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060127194032.GA18246@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox