From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27481 invoked by alias); 27 Jan 2006 19:40:36 -0000 Received: (qmail 27471 invoked by uid 22791); 27 Jan 2006 19:40:35 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 27 Jan 2006 19:40:34 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1F2ZSS-0004kx-IY for gdb-patches@sourceware.org; Fri, 27 Jan 2006 14:40:32 -0500 Date: Fri, 27 Jan 2006 19:40:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [RFA] fix build failure on ppc-aix Message-ID: <20060127194032.GA18246@nevyn.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20060127193132.GF1203@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060127193132.GF1203@adacore.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00452.txt.bz2 On Fri, Jan 27, 2006 at 02:31:32PM -0500, Joel Brobecker wrote: > Hello, > > GDB stopped building after the fix for PR gdb/1914 was checked in. > It's a tiny copy/paste issue, where a variable used in the call to > the LIB_CREATE_INFERIOR_HOOK is not available in the context where > the code has been moved to. > > I think the attached patch provides the appropriate fix. I don't > see any other way to get the pid. I looked at the code, and it > seems to me that inferior_ptid will always be set at that point. > The only case when I wasn't completely sure is in corelow. But > I don't think that the solib code would be affected in that case > if the PID wasn't set. Would it? > > 2006-01-27 Joel Brobecker > > * infcmd.c (post_create_inferior): Fix copy/paste error introduced > in the previous change. > > Fixes the build on ppc-aix. I also ran the testsuite out of curiosity. > The results are fair for this platform. Wow, the xcoff solib code is a mess; I doubt it works right with corefiles at all, since if this gets called, it's going to do ptrace ops. But your patch is fine. -- Daniel Jacobowitz CodeSourcery