[RFC] An initial patch for PR/1961

[RFC] An initial patch for PR/1961

[Wu Zhou]

Hello all,

I did some initial analysis against PR/1961 (Pls add a test for command 
input of "-(" ).  I found this SEGV error will also pop when issuing "+)", 
"<)", ">(" and so on under gdbtui. 

My intial patch is attached as follows.  Please review.  Thanks.

2005-06-20  Wu Zhou  <woodzltc@cn.ibm.com>

	* tui/tui-win.c (parse_scrolling_args): Fix SEGV error with invalid
	scroll command.

Index: tui/tui-win.c
===================================================================
RCS file: /cvs/src/src/gdb/tui/tui-win.c,v
retrieving revision 1.25
diff -c -p -r1.25 tui-win.c
*** tui/tui-win.c	24 Feb 2005 13:51:36 -0000	1.25
--- tui/tui-win.c	20 Jun 2005 01:43:59 -0000
*************** parse_scrolling_args (char *arg, struct 
*** 1543,1549 ****
  
  	  if (*win_to_scroll == (struct tui_win_info *) NULL ||
  	      !(*win_to_scroll)->generic.is_visible)
! 	    warning (_("Invalid window specified. \n\
  The window name specified must be valid and visible.\n"));
  	  else if (*win_to_scroll == TUI_CMD_WIN)
  	    *win_to_scroll = (struct tui_win_info *) (tui_source_windows ())->list[0];
--- 1543,1549 ----
  
  	  if (*win_to_scroll == (struct tui_win_info *) NULL ||
  	      !(*win_to_scroll)->generic.is_visible)
! 	    error (_("Invalid window specified. \n\
  The window name specified must be valid and visible.\n"));
  	  else if (*win_to_scroll == TUI_CMD_WIN)
  	    *win_to_scroll = (struct tui_win_info *) (tui_source_windows ())->list[0];


Cheers
- Wu Zhou

Re: [RFC] An initial patch for PR/1961

[Daniel Jacobowitz]

On Sun, Jun 19, 2005 at 12:02:14AM +0800, Wu Zhou wrote:
> Hello all,
> 
> I did some initial analysis against PR/1961 (Pls add a test for command 
> input of "-(" ).  I found this SEGV error will also pop when issuing "+)", 
> "<)", ">(" and so on under gdbtui. 
> 
> My intial patch is attached as follows.  Please review.  Thanks.
> 
> 2005-06-20  Wu Zhou  <woodzltc@cn.ibm.com>
> 
> 	* tui/tui-win.c (parse_scrolling_args): Fix SEGV error with invalid
> 	scroll command.

Please update the copyright year in this file.  Otherwise, this patch
is OK.  Thanks!

-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: [RFC] An initial patch for PR/1961

[Wu Zhou]

On Sun, 3 Jul 2005, Daniel Jacobowitz wrote:

> On Sun, Jun 19, 2005 at 12:02:14AM +0800, Wu Zhou wrote:
> > Hello all,
> > 
> > I did some initial analysis against PR/1961 (Pls add a test for command 
> > input of "-(" ).  I found this SEGV error will also pop when issuing "+)", 
> > "<)", ">(" and so on under gdbtui. 
> > 
> > My intial patch is attached as follows.  Please review.  Thanks.
> > 
> > 2005-06-20  Wu Zhou  <woodzltc@cn.ibm.com>
> > 
> > 	* tui/tui-win.c (parse_scrolling_args): Fix SEGV error with invalid
> > 	scroll command.
> 
> Please update the copyright year in this file.  Otherwise, this patch
> is OK.  Thanks!

Copyright year is updated and patch committed.

BTW.  I ever thought of adding a testcase to verify this, but found that 
gdb will timeout while waiting for the tui output under expect's control.
Is there any method to work around this?  More generally, is there any way 
to test TUI interface using expect? (I don't find any tests for TUI under 
the testsuite directory.)  Maybe it is desirable for TUI to receive enough 
test just like what MI had done. 

Just my two cents anyway.  Comments are highly appreciated.

Cheers
- Wu Zhou