From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13864 invoked by alias); 20 Jun 2005 01:56:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13851 invoked by uid 22791); 20 Jun 2005 01:56:24 -0000 Received: from ausmtp01.au.ibm.com (HELO ausmtp01.au.ibm.com) (202.81.18.186) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 20 Jun 2005 01:56:24 +0000 Received: from sd0208e0.au.ibm.com (d23rh904.au.ibm.com [202.81.18.202]) by ausmtp01.au.ibm.com (8.12.10/8.12.10) with ESMTP id j5K1wgeU012192 for ; Mon, 20 Jun 2005 11:58:45 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.250.243]) by sd0208e0.au.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j5K1x8xI124548 for ; Mon, 20 Jun 2005 11:59:08 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.12.11/8.13.3) with ESMTP id j5K1uDb6016263 for ; Mon, 20 Jun 2005 11:56:13 +1000 Received: from wks190384wss.cn.ibm.com (wks190384wss.cn.ibm.com [9.181.134.93] (may be forged)) by d23av02.au.ibm.com (8.12.11/8.12.11) with ESMTP id j5K1uBwD016130 for ; Mon, 20 Jun 2005 11:56:12 +1000 Date: Mon, 20 Jun 2005 01:56:00 -0000 From: Wu Zhou X-X-Sender: woodzltc@localhost.localdomain To: gdb-patches@sources.redhat.com Subject: [RFC] An initial patch for PR/1961 Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2005-06/txt/msg00307.txt.bz2 Hello all, I did some initial analysis against PR/1961 (Pls add a test for command input of "-(" ). I found this SEGV error will also pop when issuing "+)", "<)", ">(" and so on under gdbtui. My intial patch is attached as follows. Please review. Thanks. 2005-06-20 Wu Zhou * tui/tui-win.c (parse_scrolling_args): Fix SEGV error with invalid scroll command. Index: tui/tui-win.c =================================================================== RCS file: /cvs/src/src/gdb/tui/tui-win.c,v retrieving revision 1.25 diff -c -p -r1.25 tui-win.c *** tui/tui-win.c 24 Feb 2005 13:51:36 -0000 1.25 --- tui/tui-win.c 20 Jun 2005 01:43:59 -0000 *************** parse_scrolling_args (char *arg, struct *** 1543,1549 **** if (*win_to_scroll == (struct tui_win_info *) NULL || !(*win_to_scroll)->generic.is_visible) ! warning (_("Invalid window specified. \n\ The window name specified must be valid and visible.\n")); else if (*win_to_scroll == TUI_CMD_WIN) *win_to_scroll = (struct tui_win_info *) (tui_source_windows ())->list[0]; --- 1543,1549 ---- if (*win_to_scroll == (struct tui_win_info *) NULL || !(*win_to_scroll)->generic.is_visible) ! error (_("Invalid window specified. \n\ The window name specified must be valid and visible.\n")); else if (*win_to_scroll == TUI_CMD_WIN) *win_to_scroll = (struct tui_win_info *) (tui_source_windows ())->list[0]; Cheers - Wu Zhou