From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30272 invoked by alias); 6 Jul 2005 07:50:23 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30246 invoked by uid 22791); 6 Jul 2005 07:50:17 -0000 Received: from ausmtp01.au.ibm.com (HELO ausmtp01.au.ibm.com) (202.81.18.186) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 06 Jul 2005 07:50:17 +0000 Received: from sd0112e0.au.ibm.com (d23rh903.au.ibm.com [202.81.18.201]) by ausmtp01.au.ibm.com (8.12.10/8.12.10) with ESMTP id j667pGjd155624 for ; Wed, 6 Jul 2005 17:52:34 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.250.243]) by sd0112e0.au.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j667p1U9058778 for ; Wed, 6 Jul 2005 17:51:03 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.12.11/8.13.3) with ESMTP id j667m5ul010026 for ; Wed, 6 Jul 2005 17:48:05 +1000 Received: from [9.181.134.93] ([9.181.134.93]) by d23av02.au.ibm.com (8.12.11/8.12.11) with ESMTP id j667ltOh009598; Wed, 6 Jul 2005 17:48:04 +1000 Date: Wed, 06 Jul 2005 07:50:00 -0000 From: Wu Zhou To: Daniel Jacobowitz cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] An initial patch for PR/1961 In-Reply-To: <20050703191243.GL13811@nevyn.them.org> Message-ID: References: <20050703191243.GL13811@nevyn.them.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2005-07/txt/msg00066.txt.bz2 On Sun, 3 Jul 2005, Daniel Jacobowitz wrote: > On Sun, Jun 19, 2005 at 12:02:14AM +0800, Wu Zhou wrote: > > Hello all, > > > > I did some initial analysis against PR/1961 (Pls add a test for command > > input of "-(" ). I found this SEGV error will also pop when issuing "+)", > > "<)", ">(" and so on under gdbtui. > > > > My intial patch is attached as follows. Please review. Thanks. > > > > 2005-06-20 Wu Zhou > > > > * tui/tui-win.c (parse_scrolling_args): Fix SEGV error with invalid > > scroll command. > > Please update the copyright year in this file. Otherwise, this patch > is OK. Thanks! Copyright year is updated and patch committed. BTW. I ever thought of adding a testcase to verify this, but found that gdb will timeout while waiting for the tui output under expect's control. Is there any method to work around this? More generally, is there any way to test TUI interface using expect? (I don't find any tests for TUI under the testsuite directory.) Maybe it is desirable for TUI to receive enough test just like what MI had done. Just my two cents anyway. Comments are highly appreciated. Cheers - Wu Zhou