Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Wu Zhou <woodzltc@cn.ibm.com>
To: gdb-patches@sources.redhat.com
Subject: [RFC] An initial patch for PR/1961
Date: Mon, 20 Jun 2005 01:56:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.63.0506182358130.2656@localhost.localdomain> (raw)

Hello all,

I did some initial analysis against PR/1961 (Pls add a test for command 
input of "-(" ).  I found this SEGV error will also pop when issuing "+)", 
"<)", ">(" and so on under gdbtui. 

My intial patch is attached as follows.  Please review.  Thanks.

2005-06-20  Wu Zhou  <woodzltc@cn.ibm.com>

	* tui/tui-win.c (parse_scrolling_args): Fix SEGV error with invalid
	scroll command.

Index: tui/tui-win.c
===================================================================
RCS file: /cvs/src/src/gdb/tui/tui-win.c,v
retrieving revision 1.25
diff -c -p -r1.25 tui-win.c
*** tui/tui-win.c	24 Feb 2005 13:51:36 -0000	1.25
--- tui/tui-win.c	20 Jun 2005 01:43:59 -0000
*************** parse_scrolling_args (char *arg, struct 
*** 1543,1549 ****
  
  	  if (*win_to_scroll == (struct tui_win_info *) NULL ||
  	      !(*win_to_scroll)->generic.is_visible)
! 	    warning (_("Invalid window specified. \n\
  The window name specified must be valid and visible.\n"));
  	  else if (*win_to_scroll == TUI_CMD_WIN)
  	    *win_to_scroll = (struct tui_win_info *) (tui_source_windows ())->list[0];
--- 1543,1549 ----
  
  	  if (*win_to_scroll == (struct tui_win_info *) NULL ||
  	      !(*win_to_scroll)->generic.is_visible)
! 	    error (_("Invalid window specified. \n\
  The window name specified must be valid and visible.\n"));
  	  else if (*win_to_scroll == TUI_CMD_WIN)
  	    *win_to_scroll = (struct tui_win_info *) (tui_source_windows ())->list[0];


Cheers
- Wu Zhou


             reply	other threads:[~2005-06-20  1:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-20  1:56 Wu Zhou [this message]
2005-07-03 19:12 ` Daniel Jacobowitz
2005-07-06  7:50   ` Wu Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.63.0506182358130.2656@localhost.localdomain \
    --to=woodzltc@cn.ibm.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox