* [RFA] i386-tdep.c: Fix datatype
@ 2005-06-23 16:36 Corinna Vinschen
2005-06-23 20:54 ` Mark Kettenis
0 siblings, 1 reply; 3+ messages in thread
From: Corinna Vinschen @ 2005-06-23 16:36 UTC (permalink / raw)
To: gdb-patches
Hi,
the below patch is just a minor tweak. The stack pointer offset sp_offset
stored in struct i386_frame_cache is an offset, not an address. It looks
more correct to define it as LONGEST, not as CORE_ADDR. Especially since
sp_offset can contain positve and negative values.
Corinna
* i386-tdep.c (struct i386_frame_cache): Define sp_offset as LONGEST.
Index: i386-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-tdep.c,v
retrieving revision 1.214
diff -u -p -r1.214 i386-tdep.c
--- i386-tdep.c 11 Jun 2005 19:11:32 -0000 1.214
+++ i386-tdep.c 23 Jun 2005 16:33:04 -0000
@@ -289,7 +289,7 @@ struct i386_frame_cache
{
/* Base address. */
CORE_ADDR base;
- CORE_ADDR sp_offset;
+ LONGEST sp_offset;
CORE_ADDR pc;
/* Saved registers. */
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat, Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFA] i386-tdep.c: Fix datatype
2005-06-23 16:36 [RFA] i386-tdep.c: Fix datatype Corinna Vinschen
@ 2005-06-23 20:54 ` Mark Kettenis
2005-06-24 8:13 ` Corinna Vinschen
0 siblings, 1 reply; 3+ messages in thread
From: Mark Kettenis @ 2005-06-23 20:54 UTC (permalink / raw)
To: gdb-patches
Date: Thu, 23 Jun 2005 18:36:37 +0200
From: Corinna Vinschen <vinschen@redhat.com>
Hi,
the below patch is just a minor tweak. The stack pointer offset sp_offset
stored in struct i386_frame_cache is an offset, not an address. It looks
more correct to define it as LONGEST, not as CORE_ADDR. Especially since
sp_offset can contain positve and negative values.
Corinna
* i386-tdep.c (struct i386_frame_cache): Define sp_offset as LONGEST.
Aauming this compiles with -Werror (and I have no reason to suspect
that it wouldn't, this is ok.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] i386-tdep.c: Fix datatype
2005-06-23 20:54 ` Mark Kettenis
@ 2005-06-24 8:13 ` Corinna Vinschen
0 siblings, 0 replies; 3+ messages in thread
From: Corinna Vinschen @ 2005-06-24 8:13 UTC (permalink / raw)
To: gdb-patches
On Jun 23 22:54, Mark Kettenis wrote:
> Date: Thu, 23 Jun 2005 18:36:37 +0200
> From: Corinna Vinschen <vinschen@redhat.com>
>
> Hi,
>
> the below patch is just a minor tweak. The stack pointer offset sp_offset
> stored in struct i386_frame_cache is an offset, not an address. It looks
> more correct to define it as LONGEST, not as CORE_ADDR. Especially since
> sp_offset can contain positve and negative values.
>
> Corinna
>
> * i386-tdep.c (struct i386_frame_cache): Define sp_offset as LONGEST.
>
> Aauming this compiles with -Werror (and I have no reason to suspect
> that it wouldn't, this is ok.
It compiles fine with -Werror, so I checked it in.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat, Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-06-24 8:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-06-23 16:36 [RFA] i386-tdep.c: Fix datatype Corinna Vinschen
2005-06-23 20:54 ` Mark Kettenis
2005-06-24 8:13 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox