From: Corinna Vinschen <vinschen@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA] i386-tdep.c: Fix datatype
Date: Thu, 23 Jun 2005 16:36:00 -0000 [thread overview]
Message-ID: <20050623163637.GS2814@calimero.vinschen.de> (raw)
Hi,
the below patch is just a minor tweak. The stack pointer offset sp_offset
stored in struct i386_frame_cache is an offset, not an address. It looks
more correct to define it as LONGEST, not as CORE_ADDR. Especially since
sp_offset can contain positve and negative values.
Corinna
* i386-tdep.c (struct i386_frame_cache): Define sp_offset as LONGEST.
Index: i386-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-tdep.c,v
retrieving revision 1.214
diff -u -p -r1.214 i386-tdep.c
--- i386-tdep.c 11 Jun 2005 19:11:32 -0000 1.214
+++ i386-tdep.c 23 Jun 2005 16:33:04 -0000
@@ -289,7 +289,7 @@ struct i386_frame_cache
{
/* Base address. */
CORE_ADDR base;
- CORE_ADDR sp_offset;
+ LONGEST sp_offset;
CORE_ADDR pc;
/* Saved registers. */
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat, Inc.
next reply other threads:[~2005-06-23 16:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-23 16:36 Corinna Vinschen [this message]
2005-06-23 20:54 ` Mark Kettenis
2005-06-24 8:13 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050623163637.GS2814@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox