From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-40125-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 18549 invoked by alias); 23 Jun 2005 16:36:45 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 18537 invoked by uid 22791); 23 Jun 2005 16:36:42 -0000
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 23 Jun 2005 16:36:42 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j5NGafJ6009842
	for <gdb-patches@sources.redhat.com>; Thu, 23 Jun 2005 12:36:41 -0400
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j5NGaau12961
	for <gdb-patches@sources.redhat.com>; Thu, 23 Jun 2005 12:36:36 -0400
Received: from calimero.vinschen.de (vpn50-40.rdu.redhat.com [172.16.50.40])
	by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id j5NGaXWM015203
	for <gdb-patches@sources.redhat.com>; Thu, 23 Jun 2005 12:36:34 -0400
Received: by calimero.vinschen.de (Postfix, from userid 500)
	id DA4F2544122; Thu, 23 Jun 2005 18:36:37 +0200 (CEST)
Date: Thu, 23 Jun 2005 16:36:00 -0000
From: Corinna Vinschen <vinschen@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA] i386-tdep.c: Fix datatype
Message-ID: <20050623163637.GS2814@calimero.vinschen.de>
Reply-To: gdb-patches@sources.redhat.com
Mail-Followup-To: gdb-patches@sources.redhat.com
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4.2i
X-SW-Source: 2005-06/txt/msg00358.txt.bz2

Hi,

the below patch is just a minor tweak.  The stack pointer offset sp_offset
stored in struct i386_frame_cache is an offset, not an address.  It looks
more correct to define it as LONGEST, not as CORE_ADDR.  Especially since
sp_offset can contain positve and negative values.


Corinna

	* i386-tdep.c (struct i386_frame_cache): Define sp_offset as LONGEST.

Index: i386-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-tdep.c,v
retrieving revision 1.214
diff -u -p -r1.214 i386-tdep.c
--- i386-tdep.c 11 Jun 2005 19:11:32 -0000      1.214
+++ i386-tdep.c 23 Jun 2005 16:33:04 -0000
@@ -289,7 +289,7 @@ struct i386_frame_cache
 {
   /* Base address.  */
   CORE_ADDR base;
-  CORE_ADDR sp_offset;
+  LONGEST sp_offset;
   CORE_ADDR pc;
 
   /* Saved registers.  */

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat, Inc.