From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31028 invoked by alias); 23 Jun 2005 20:54:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31019 invoked by uid 22791); 23 Jun 2005 20:54:39 -0000 Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 23 Jun 2005 20:54:39 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j5NKsa46022190 for ; Thu, 23 Jun 2005 22:54:37 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j5NKsau4006968 for ; Thu, 23 Jun 2005 22:54:36 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j5NKsW15023041; Thu, 23 Jun 2005 22:54:32 +0200 (CEST) Date: Thu, 23 Jun 2005 20:54:00 -0000 Message-Id: <200506232054.j5NKsW15023041@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: gdb-patches@sources.redhat.com In-reply-to: <20050623163637.GS2814@calimero.vinschen.de> (message from Corinna Vinschen on Thu, 23 Jun 2005 18:36:37 +0200) Subject: Re: [RFA] i386-tdep.c: Fix datatype References: <20050623163637.GS2814@calimero.vinschen.de> X-SW-Source: 2005-06/txt/msg00360.txt.bz2 Date: Thu, 23 Jun 2005 18:36:37 +0200 From: Corinna Vinschen Hi, the below patch is just a minor tweak. The stack pointer offset sp_offset stored in struct i386_frame_cache is an offset, not an address. It looks more correct to define it as LONGEST, not as CORE_ADDR. Especially since sp_offset can contain positve and negative values. Corinna * i386-tdep.c (struct i386_frame_cache): Define sp_offset as LONGEST. Aauming this compiles with -Werror (and I have no reason to suspect that it wouldn't, this is ok. Thanks, Mark