From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15275 invoked by alias); 24 Jun 2005 08:13:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15240 invoked by uid 22791); 24 Jun 2005 08:13:07 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 24 Jun 2005 08:13:07 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j5O8D5EY007617 for ; Fri, 24 Jun 2005 04:13:05 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j5O8D5u23225 for ; Fri, 24 Jun 2005 04:13:05 -0400 Received: from calimero.vinschen.de (vpn50-23.rdu.redhat.com [172.16.50.23]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id j5O8D2WM024827 for ; Fri, 24 Jun 2005 04:13:03 -0400 Received: by calimero.vinschen.de (Postfix, from userid 500) id 2C669544122; Fri, 24 Jun 2005 10:13:06 +0200 (CEST) Date: Fri, 24 Jun 2005 08:13:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA] i386-tdep.c: Fix datatype Message-ID: <20050624081306.GB2814@calimero.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <20050623163637.GS2814@calimero.vinschen.de> <200506232054.j5NKsW15023041@elgar.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200506232054.j5NKsW15023041@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.4.2i X-SW-Source: 2005-06/txt/msg00361.txt.bz2 On Jun 23 22:54, Mark Kettenis wrote: > Date: Thu, 23 Jun 2005 18:36:37 +0200 > From: Corinna Vinschen > > Hi, > > the below patch is just a minor tweak. The stack pointer offset sp_offset > stored in struct i386_frame_cache is an offset, not an address. It looks > more correct to define it as LONGEST, not as CORE_ADDR. Especially since > sp_offset can contain positve and negative values. > > Corinna > > * i386-tdep.c (struct i386_frame_cache): Define sp_offset as LONGEST. > > Aauming this compiles with -Werror (and I have no reason to suspect > that it wouldn't, this is ok. It compiles fine with -Werror, so I checked it in. Thanks, Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat, Inc.