Re: i18n, part 2

[Daniel Jacobowitz <drow@false.org>]

On Sat, Dec 04, 2004 at 08:57:02PM +0100, Baurjan Ismagulov wrote:
> * arm-tdep.c:_initialize_arm_tdep()
> 
>   The text "\
> When off, a 26-bit PC will be used.\n\
> When off, a 26-bit PC will be used." looked strange to me, is it
>   indended to be so?

When the help_doc argument was added to this function, a lot of uses
were converted in batch.  It looks like this one was just a typo.  Old
GDB would print:

(gdb) help show arm apcs32
Show usage of ARM 32-bit mode.  When off, a 26-bit PC will be used.

New GDB prints:

(gdb) help show arm apcs32
Show usage of ARM 32-bit mode.
When off, a 26-bit PC will be used.
When off, a 26-bit PC will be used.

[In the old interface, the whole thing was one translatable message. 
Now it is two, on separate lines.]

>  	      internal_error (__FILE__, __LINE__,
> -			      "arm_elf_osabi_sniffer: Unknown ARM EABI "
> -			      "version 0x%x", eflags);
> +			      _("arm_elf_osabi_sniffer: Unknown ARM EABI \
> +version 0x%x"), eflags);

GDB is already inconsistent about this, but does the "" "" style of
string concatenation cause any problem for gettext?  Otherwise, I
mildly prefer it - it prevents diff -p from getting confused about the
function name.


-- 
Daniel Jacobowitz