From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32261 invoked by alias); 4 Dec 2004 20:06:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32249 invoked from network); 4 Dec 2004 20:06:09 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 4 Dec 2004 20:06:09 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1CagAP-000492-87 for ; Sat, 04 Dec 2004 15:06:05 -0500 Date: Sat, 04 Dec 2004 21:52:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: i18n, part 2 Message-ID: <20041204200605.GA15732@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20041204195702.GA25306@ata.cs.hun.edu.tr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041204195702.GA25306@ata.cs.hun.edu.tr> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-12/txt/msg00121.txt.bz2 On Sat, Dec 04, 2004 at 08:57:02PM +0100, Baurjan Ismagulov wrote: > * arm-tdep.c:_initialize_arm_tdep() > > The text "\ > When off, a 26-bit PC will be used.\n\ > When off, a 26-bit PC will be used." looked strange to me, is it > indended to be so? When the help_doc argument was added to this function, a lot of uses were converted in batch. It looks like this one was just a typo. Old GDB would print: (gdb) help show arm apcs32 Show usage of ARM 32-bit mode. When off, a 26-bit PC will be used. New GDB prints: (gdb) help show arm apcs32 Show usage of ARM 32-bit mode. When off, a 26-bit PC will be used. When off, a 26-bit PC will be used. [In the old interface, the whole thing was one translatable message. Now it is two, on separate lines.] > internal_error (__FILE__, __LINE__, > - "arm_elf_osabi_sniffer: Unknown ARM EABI " > - "version 0x%x", eflags); > + _("arm_elf_osabi_sniffer: Unknown ARM EABI \ > +version 0x%x"), eflags); GDB is already inconsistent about this, but does the "" "" style of string concatenation cause any problem for gettext? Otherwise, I mildly prefer it - it prevents diff -p from getting confused about the function name. -- Daniel Jacobowitz