[RFA] testsuite/gdb.base/attach.exp: Add missing kill -9

[RFA] testsuite/gdb.base/attach.exp: Add missing kill -9

[Corinna Vinschen]

Hi,

the below patch fixes the problem when due to GDB problems the attach 
process keeps running.  In two cases, the process is killed, but at the
end of do_attach_tests, the kill is missing.

Ok to check in?

Corinna

Index: gdb.base/attach.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/attach.exp,v
retrieving revision 1.12
diff -u -p -r1.12 attach.exp
--- gdb.base/attach.exp	7 Aug 2003 17:55:41 -0000	1.12
+++ gdb.base/attach.exp	25 Jun 2004 12:24:07 -0000
@@ -1,4 +1,4 @@
-#   Copyright 1997, 1999, 2002 Free Software Foundation, Inc.
+#   Copyright 1997, 1999, 2002, 2004 Free Software Foundation, Inc.
 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -355,6 +355,9 @@ proc do_attach_tests {} {
       -re "$gdb_prompt $" {fail "after attach3, exit"}
       timeout         {fail "(timeout) after attach3, exit"}
    }
+
+   # Another "don't leave a process around"
+   remote_exec build "kill -9 ${testpid}"
 }
 
 proc do_call_attach_tests {} {


-- 
Corinna Vinschen
Cygwin Co-Project Leader
Red Hat, Inc.

Re: [RFA] testsuite/gdb.base/attach.exp: Add missing kill -9

[Daniel Jacobowitz]

On Fri, Jun 25, 2004 at 02:24:35PM +0200, Corinna Vinschen wrote:
> Hi,
> 
> the below patch fixes the problem when due to GDB problems the attach 
> process keeps running.  In two cases, the process is killed, but at the
> end of do_attach_tests, the kill is missing.
> 
> Ok to check in?

No changelog, but otherwise OK.  Thanks - this one comes up in the
Debian autobuilders periodically.

> 
> Corinna
> 
> Index: gdb.base/attach.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/attach.exp,v
> retrieving revision 1.12
> diff -u -p -r1.12 attach.exp
> --- gdb.base/attach.exp	7 Aug 2003 17:55:41 -0000	1.12
> +++ gdb.base/attach.exp	25 Jun 2004 12:24:07 -0000
> @@ -1,4 +1,4 @@
> -#   Copyright 1997, 1999, 2002 Free Software Foundation, Inc.
> +#   Copyright 1997, 1999, 2002, 2004 Free Software Foundation, Inc.
>  
>  # This program is free software; you can redistribute it and/or modify
>  # it under the terms of the GNU General Public License as published by
> @@ -355,6 +355,9 @@ proc do_attach_tests {} {
>        -re "$gdb_prompt $" {fail "after attach3, exit"}
>        timeout         {fail "(timeout) after attach3, exit"}
>     }
> +
> +   # Another "don't leave a process around"
> +   remote_exec build "kill -9 ${testpid}"
>  }
>  
>  proc do_call_attach_tests {} {
> 
> 
> -- 
> Corinna Vinschen
> Cygwin Co-Project Leader
> Red Hat, Inc.
> 

-- 
Daniel Jacobowitz

Re: [RFA] testsuite/gdb.base/attach.exp: Add missing kill -9

[Corinna Vinschen]

On Jun 25 09:35, Daniel Jacobowitz wrote:
> On Fri, Jun 25, 2004 at 02:24:35PM +0200, Corinna Vinschen wrote:
> > Hi,
> > 
> > the below patch fixes the problem when due to GDB problems the attach 
> > process keeps running.  In two cases, the process is killed, but at the
> > end of do_attach_tests, the kill is missing.
> > 
> > Ok to check in?
> 
> No changelog, but otherwise OK.  Thanks - this one comes up in the
> Debian autobuilders periodically.

Thanks, I applied it with the following ChangeLog entry:

        * gdb.base/attach.exp (do_attach_tests): Don't forget to kill second
	attach process.

Corinna

-- 
Corinna Vinschen
Cygwin Co-Project Leader
Red Hat, Inc.

Re: [RFA] testsuite/gdb.base/attach.exp: Add missing kill -9

[Michael Elizabeth Chastain]

Hi Corinna,

Can you add 2003 to the list of copyright years as well --
the file was last modified in 2003 (several times in fact).

Also, how did you test this patch?

Finally, it needs a ChangeLog entry.

(And Daniel, if you're going to approve patches in testsuite/,
please ask people how they are tested.)

Michael C

Re: [RFA] testsuite/gdb.base/attach.exp: Add missing kill -9

[Corinna Vinschen]

Hi Michael,

On Jun 25 11:35, Michael Elizabeth Chastain wrote:
> Can you add 2003 to the list of copyright years as well --
> the file was last modified in 2003 (several times in fact).

I'll add it with my next patch (which probably comes today anyway).

> Also, how did you test this patch?

Erm... that's a funny question.  I tested the testcase by running it.
Actually, without further changes this problem hits Cygwin.  Adding
this patch solves the problem.

Corinna

-- 
Corinna Vinschen
Cygwin Co-Project Leader
Red Hat, Inc.

Re: [RFA] testsuite/gdb.base/attach.exp: Add missing kill -9

[Michael Elizabeth Chastain]

[Oops, I sent this to gdb-patches@redhat.com instead of
 gdb-patches@sources.redhat.com]

cv> I'll add it with my next patch (which probably comes today anyway).

Okay.

mec> Also, how did you test this patch?
cv> Erm... that's a funny question.  I tested the testcase by running it.

If you could just say "I ran it on Cygwin" (or whatever you ran it on),
that would be fine.

When some patch breaks, I find it's helpful to know what platform
it actually did work on back when it was submitted.

Michael C