Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] testsuite/gdb.base/attach.exp: Add missing kill -9
Date: Fri, 25 Jun 2004 13:35:00 -0000	[thread overview]
Message-ID: <20040625133523.GB21788@nevyn.them.org> (raw)
In-Reply-To: <20040625122435.GA32135@cygbert.vinschen.de>

On Fri, Jun 25, 2004 at 02:24:35PM +0200, Corinna Vinschen wrote:
> Hi,
> 
> the below patch fixes the problem when due to GDB problems the attach 
> process keeps running.  In two cases, the process is killed, but at the
> end of do_attach_tests, the kill is missing.
> 
> Ok to check in?

No changelog, but otherwise OK.  Thanks - this one comes up in the
Debian autobuilders periodically.

> 
> Corinna
> 
> Index: gdb.base/attach.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/attach.exp,v
> retrieving revision 1.12
> diff -u -p -r1.12 attach.exp
> --- gdb.base/attach.exp	7 Aug 2003 17:55:41 -0000	1.12
> +++ gdb.base/attach.exp	25 Jun 2004 12:24:07 -0000
> @@ -1,4 +1,4 @@
> -#   Copyright 1997, 1999, 2002 Free Software Foundation, Inc.
> +#   Copyright 1997, 1999, 2002, 2004 Free Software Foundation, Inc.
>  
>  # This program is free software; you can redistribute it and/or modify
>  # it under the terms of the GNU General Public License as published by
> @@ -355,6 +355,9 @@ proc do_attach_tests {} {
>        -re "$gdb_prompt $" {fail "after attach3, exit"}
>        timeout         {fail "(timeout) after attach3, exit"}
>     }
> +
> +   # Another "don't leave a process around"
> +   remote_exec build "kill -9 ${testpid}"
>  }
>  
>  proc do_call_attach_tests {} {
> 
> 
> -- 
> Corinna Vinschen
> Cygwin Co-Project Leader
> Red Hat, Inc.
> 

-- 
Daniel Jacobowitz


  reply	other threads:[~2004-06-25 13:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-25 12:24 Corinna Vinschen
2004-06-25 13:35 ` Daniel Jacobowitz [this message]
2004-06-25 13:52   ` Corinna Vinschen
2004-06-25 15:35 Michael Elizabeth Chastain
2004-06-26  8:13 ` Corinna Vinschen
2004-06-26 16:18 Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040625133523.GB21788@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox