Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: mec.gnu@mindspring.com (Michael Elizabeth Chastain)
To: gdb-patches@sources.redhat.com
Cc: vinschen@redhat.com
Subject: Re: [RFA] testsuite/gdb.base/attach.exp: Add missing kill -9
Date: Fri, 25 Jun 2004 15:35:00 -0000	[thread overview]
Message-ID: <20040625153552.A12DD4B104@berman.michael-chastain.com> (raw)

Hi Corinna,

Can you add 2003 to the list of copyright years as well --
the file was last modified in 2003 (several times in fact).

Also, how did you test this patch?

Finally, it needs a ChangeLog entry.

(And Daniel, if you're going to approve patches in testsuite/,
please ask people how they are tested.)

Michael C


             reply	other threads:[~2004-06-25 15:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-25 15:35 Michael Elizabeth Chastain [this message]
2004-06-26  8:13 ` Corinna Vinschen
  -- strict thread matches above, loose matches on Subject: below --
2004-06-26 16:18 Michael Elizabeth Chastain
2004-06-25 12:24 Corinna Vinschen
2004-06-25 13:35 ` Daniel Jacobowitz
2004-06-25 13:52   ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040625153552.A12DD4B104@berman.michael-chastain.com \
    --to=mec.gnu@mindspring.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vinschen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox