From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27610 invoked by alias); 25 Jun 2004 13:35:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27345 invoked from network); 25 Jun 2004 13:35:24 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 25 Jun 2004 13:35:24 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1BdqrT-0005ph-Jp for ; Fri, 25 Jun 2004 09:35:23 -0400 Date: Fri, 25 Jun 2004 13:35:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [RFA] testsuite/gdb.base/attach.exp: Add missing kill -9 Message-ID: <20040625133523.GB21788@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20040625122435.GA32135@cygbert.vinschen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040625122435.GA32135@cygbert.vinschen.de> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-06/txt/msg00531.txt.bz2 On Fri, Jun 25, 2004 at 02:24:35PM +0200, Corinna Vinschen wrote: > Hi, > > the below patch fixes the problem when due to GDB problems the attach > process keeps running. In two cases, the process is killed, but at the > end of do_attach_tests, the kill is missing. > > Ok to check in? No changelog, but otherwise OK. Thanks - this one comes up in the Debian autobuilders periodically. > > Corinna > > Index: gdb.base/attach.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/attach.exp,v > retrieving revision 1.12 > diff -u -p -r1.12 attach.exp > --- gdb.base/attach.exp 7 Aug 2003 17:55:41 -0000 1.12 > +++ gdb.base/attach.exp 25 Jun 2004 12:24:07 -0000 > @@ -1,4 +1,4 @@ > -# Copyright 1997, 1999, 2002 Free Software Foundation, Inc. > +# Copyright 1997, 1999, 2002, 2004 Free Software Foundation, Inc. > > # This program is free software; you can redistribute it and/or modify > # it under the terms of the GNU General Public License as published by > @@ -355,6 +355,9 @@ proc do_attach_tests {} { > -re "$gdb_prompt $" {fail "after attach3, exit"} > timeout {fail "(timeout) after attach3, exit"} > } > + > + # Another "don't leave a process around" > + remote_exec build "kill -9 ${testpid}" > } > > proc do_call_attach_tests {} { > > > -- > Corinna Vinschen > Cygwin Co-Project Leader > Red Hat, Inc. > -- Daniel Jacobowitz