[PATCH] Ping - PR1473

[PATCH] Ping - PR1473

[Paul Brook]

I submitted a patch to fix PR1473 a couple of weeks ago, but haven't recieved 
any feedback.

http://sources.redhat.com/ml/gdb-patches/2003-12/msg00426.html

I forgot to put [patch] in the subject line, so I guess it might have slipped 
past unnoticed.

Paul

Re: [PATCH] Ping - PR1473

[Daniel Jacobowitz]

On Mon, Jan 05, 2004 at 11:28:37AM +0000, Paul Brook wrote:
> I submitted a patch to fix PR1473 a couple of weeks ago, but haven't recieved 
> any feedback.
> 
> http://sources.redhat.com/ml/gdb-patches/2003-12/msg00426.html
> 
> I forgot to put [patch] in the subject line, so I guess it might have slipped 
> past unnoticed.

It slipped past because no one likes to deal with infrun :)

I don't like the idea of adding this test to keep_going.  This should
only be necessary in the BPSTAT_WHAT_CHECK_SHLIBS case, correct?

Somethng like this:

-         if (stop_on_solib_events)
+         if (stop_on_solib_events || stop_stack_dummy)

I don't know if you need a stop_print_frame=0 also if
(stop_stack_dummy).

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: [PATCH] Ping - PR1473

[Paul Brook]

On Monday 05 January 2004 9:06 pm, Daniel Jacobowitz wrote:
> I don't like the idea of adding this test to keep_going.  This should
> only be necessary in the BPSTAT_WHAT_CHECK_SHLIBS case, correct?

Yes.

> Something like this:
>
> -         if (stop_on_solib_events)
> +         if (stop_on_solib_events || stop_stack_dummy)

Updated patch appended below, ok to apply?
Tested on i686-linux.

> I don't know if you need a stop_print_frame=0 also if
> (stop_stack_dummy).

This is already handled elsewhere.

Paul

2004-01-21  Paul Brook  <paul@codesourcery.com>

	* infrun.c (handle_inferior_event): Check stop_stack_dummy if handling
	BPSTAT_CHECK_WHAT_SHLIBS.

Index: infrun.c
===================================================================
RCS file: /cvs/src/src/gdb/infrun.c,v
retrieving revision 1.130
diff -u -p -r1.130 infrun.c
--- infrun.c	19 Jan 2004 17:28:52 -0000	1.130
+++ infrun.c	21 Jan 2004 13:18:11 -0000
@@ -2301,7 +2301,7 @@ process_event_stop_test:
 	     gdb of events.  This allows the user to get control
 	     and place breakpoints in initializer routines for
 	     dynamically loaded objects (among other things).  */
-	  if (stop_on_solib_events)
+	  if (stop_on_solib_events || stop_stack_dummy)
 	    {
 	      stop_stepping (ecs);
 	      return;

Re: [PATCH] Ping - PR1473

[Daniel Jacobowitz]

On Wed, Jan 21, 2004 at 04:12:24PM +0000, Paul Brook wrote:
> On Monday 05 January 2004 9:06 pm, Daniel Jacobowitz wrote:
> > I don't like the idea of adding this test to keep_going.  This should
> > only be necessary in the BPSTAT_WHAT_CHECK_SHLIBS case, correct?
> 
> Yes.
> 
> > Something like this:
> >
> > -         if (stop_on_solib_events)
> > +         if (stop_on_solib_events || stop_stack_dummy)
> 
> Updated patch appended below, ok to apply?
> Tested on i686-linux.
>
> > I don't know if you need a stop_print_frame=0 also if
> > (stop_stack_dummy).
> 
> This is already handled elsewhere.
> 
> Paul
> 
> 2004-01-21  Paul Brook  <paul@codesourcery.com>
> 
> 	* infrun.c (handle_inferior_event): Check stop_stack_dummy if handling
> 	BPSTAT_CHECK_WHAT_SHLIBS.

Typo, it's BPSTAT_WHAT_CHECK_SHLIBS I think.

This patch is OK.  Please also add yourself to write-after-approval in
gdb/MAINTAINERS, and post the patch and changelog for that.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer