From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13894 invoked by alias); 21 Jan 2004 16:12:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13871 invoked from network); 21 Jan 2004 16:12:26 -0000 Received: from unknown (HELO pengo.systems.pipex.net) (62.241.160.193) by sources.redhat.com with SMTP; 21 Jan 2004 16:12:26 -0000 Received: from nowt.org (81-178-208-226.dsl.pipex.com [81.178.208.226]) by pengo.systems.pipex.net (Postfix) with ESMTP id B548E4C0019B; Wed, 21 Jan 2004 16:12:25 +0000 (GMT) Received: from finch.home (finch.home [192.168.1.6]) by nowt.org (Postfix) with ESMTP id 93854AC92; Wed, 21 Jan 2004 16:12:24 +0000 (GMT) From: Paul Brook Organization: CodeSourcery To: Daniel Jacobowitz , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Ping - PR1473 Date: Wed, 21 Jan 2004 16:12:00 -0000 User-Agent: KMail/1.5.4 References: <200401051128.37903.paul@codesourcery.com> <20040105210626.GA11599@nevyn.them.org> In-Reply-To: <20040105210626.GA11599@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200401211612.24246.paul@codesourcery.com> X-SW-Source: 2004-01/txt/msg00584.txt.bz2 On Monday 05 January 2004 9:06 pm, Daniel Jacobowitz wrote: > I don't like the idea of adding this test to keep_going. This should > only be necessary in the BPSTAT_WHAT_CHECK_SHLIBS case, correct? Yes. > Something like this: > > - if (stop_on_solib_events) > + if (stop_on_solib_events || stop_stack_dummy) Updated patch appended below, ok to apply? Tested on i686-linux. > I don't know if you need a stop_print_frame=0 also if > (stop_stack_dummy). This is already handled elsewhere. Paul 2004-01-21 Paul Brook * infrun.c (handle_inferior_event): Check stop_stack_dummy if handling BPSTAT_CHECK_WHAT_SHLIBS. Index: infrun.c =================================================================== RCS file: /cvs/src/src/gdb/infrun.c,v retrieving revision 1.130 diff -u -p -r1.130 infrun.c --- infrun.c 19 Jan 2004 17:28:52 -0000 1.130 +++ infrun.c 21 Jan 2004 13:18:11 -0000 @@ -2301,7 +2301,7 @@ process_event_stop_test: gdb of events. This allows the user to get control and place breakpoints in initializer routines for dynamically loaded objects (among other things). */ - if (stop_on_solib_events) + if (stop_on_solib_events || stop_stack_dummy) { stop_stepping (ecs); return;