Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: Daniel Jacobowitz <drow@mvista.com>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Ping - PR1473
Date: Wed, 21 Jan 2004 16:12:00 -0000	[thread overview]
Message-ID: <200401211612.24246.paul@codesourcery.com> (raw)
In-Reply-To: <20040105210626.GA11599@nevyn.them.org>

On Monday 05 January 2004 9:06 pm, Daniel Jacobowitz wrote:
> I don't like the idea of adding this test to keep_going.  This should
> only be necessary in the BPSTAT_WHAT_CHECK_SHLIBS case, correct?

Yes.

> Something like this:
>
> -         if (stop_on_solib_events)
> +         if (stop_on_solib_events || stop_stack_dummy)

Updated patch appended below, ok to apply?
Tested on i686-linux.

> I don't know if you need a stop_print_frame=0 also if
> (stop_stack_dummy).

This is already handled elsewhere.

Paul

2004-01-21  Paul Brook  <paul@codesourcery.com>

	* infrun.c (handle_inferior_event): Check stop_stack_dummy if handling
	BPSTAT_CHECK_WHAT_SHLIBS.

Index: infrun.c
===================================================================
RCS file: /cvs/src/src/gdb/infrun.c,v
retrieving revision 1.130
diff -u -p -r1.130 infrun.c
--- infrun.c	19 Jan 2004 17:28:52 -0000	1.130
+++ infrun.c	21 Jan 2004 13:18:11 -0000
@@ -2301,7 +2301,7 @@ process_event_stop_test:
 	     gdb of events.  This allows the user to get control
 	     and place breakpoints in initializer routines for
 	     dynamically loaded objects (among other things).  */
-	  if (stop_on_solib_events)
+	  if (stop_on_solib_events || stop_stack_dummy)
 	    {
 	      stop_stepping (ecs);
 	      return;


  reply	other threads:[~2004-01-21 16:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-05 11:28 Paul Brook
2004-01-05 21:06 ` Daniel Jacobowitz
2004-01-21 16:12   ` Paul Brook [this message]
2004-01-21 16:18     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200401211612.24246.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox