From: Daniel Jacobowitz <drow@mvista.com>
To: Paul Brook <paul@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Ping - PR1473
Date: Wed, 21 Jan 2004 16:18:00 -0000 [thread overview]
Message-ID: <20040121161801.GA3144@nevyn.them.org> (raw)
In-Reply-To: <200401211612.24246.paul@codesourcery.com>
On Wed, Jan 21, 2004 at 04:12:24PM +0000, Paul Brook wrote:
> On Monday 05 January 2004 9:06 pm, Daniel Jacobowitz wrote:
> > I don't like the idea of adding this test to keep_going. This should
> > only be necessary in the BPSTAT_WHAT_CHECK_SHLIBS case, correct?
>
> Yes.
>
> > Something like this:
> >
> > - if (stop_on_solib_events)
> > + if (stop_on_solib_events || stop_stack_dummy)
>
> Updated patch appended below, ok to apply?
> Tested on i686-linux.
>
> > I don't know if you need a stop_print_frame=0 also if
> > (stop_stack_dummy).
>
> This is already handled elsewhere.
>
> Paul
>
> 2004-01-21 Paul Brook <paul@codesourcery.com>
>
> * infrun.c (handle_inferior_event): Check stop_stack_dummy if handling
> BPSTAT_CHECK_WHAT_SHLIBS.
Typo, it's BPSTAT_WHAT_CHECK_SHLIBS I think.
This patch is OK. Please also add yourself to write-after-approval in
gdb/MAINTAINERS, and post the patch and changelog for that.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
prev parent reply other threads:[~2004-01-21 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-05 11:28 Paul Brook
2004-01-05 21:06 ` Daniel Jacobowitz
2004-01-21 16:12 ` Paul Brook
2004-01-21 16:18 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040121161801.GA3144@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=paul@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox