[PATCH/RFC] Fix compilation warning in breakpoint.c

[PATCH/RFC] Fix compilation warning in breakpoint.c

[Mark Kettenis]

The newest GCC complains about us passing NULL as one of the arguments
to strcmp().  This patch fixes the problem.  It's similar to what we
do for SOLIB_LOADED_LIBRARY_PATHNAME.  I wonder whether is would be
better to get rid of these definitions in solib.h altogether, and rely
on the defaults in breakpoint.h.  Thoughts?

Meanwhile, I committed the attached as obvious.

Mark


Index: ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* solib.h (SOLIB_UNLOADED_LIBRARY_PATHNAME): Define as "" instead
	of (0).

Index: solib.h
===================================================================
RCS file: /cvs/src/src/gdb/solib.h,v
retrieving revision 1.10
diff -u -p -r1.10 solib.h
--- solib.h 10 Jul 2003 21:56:25 -0000 1.10
+++ solib.h 11 Dec 2003 13:38:34 -0000
@@ -149,7 +149,7 @@ extern void solib_create_inferior_hook (
  */
 
 #define SOLIB_UNLOADED_LIBRARY_PATHNAME(pid) \
-(0)
+""
 
 /* This function returns TRUE if pc is the address of an instruction that
    lies within the dynamic linker (such as the event hook, or the dld

Re: [PATCH/RFC] Fix compilation warning in breakpoint.c

[Kevin Buettner]

On Dec 11,  2:45pm, Mark Kettenis wrote:

> The newest GCC complains about us passing NULL as one of the arguments
> to strcmp().  This patch fixes the problem.  It's similar to what we
> do for SOLIB_LOADED_LIBRARY_PATHNAME.  I wonder whether is would be
> better to get rid of these definitions in solib.h altogether, and rely
> on the defaults in breakpoint.h.  Thoughts?

I think it makes sense to remove the solib.h definitions that
breakpoint.h already provides defaults for.  If you want to do this,
consider the solib.h changes to be preapproved.

Kevin