Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <kettenis@chello.nl>
To: gdb-patches@sources.redhat.com
Subject: [PATCH/RFC] Fix compilation warning in breakpoint.c
Date: Thu, 11 Dec 2003 13:45:00 -0000	[thread overview]
Message-ID: <200312111345.hBBDjIew000479@elgar.kettenis.dyndns.org> (raw)

The newest GCC complains about us passing NULL as one of the arguments
to strcmp().  This patch fixes the problem.  It's similar to what we
do for SOLIB_LOADED_LIBRARY_PATHNAME.  I wonder whether is would be
better to get rid of these definitions in solib.h altogether, and rely
on the defaults in breakpoint.h.  Thoughts?

Meanwhile, I committed the attached as obvious.

Mark


Index: ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* solib.h (SOLIB_UNLOADED_LIBRARY_PATHNAME): Define as "" instead
	of (0).

Index: solib.h
===================================================================
RCS file: /cvs/src/src/gdb/solib.h,v
retrieving revision 1.10
diff -u -p -r1.10 solib.h
--- solib.h 10 Jul 2003 21:56:25 -0000 1.10
+++ solib.h 11 Dec 2003 13:38:34 -0000
@@ -149,7 +149,7 @@ extern void solib_create_inferior_hook (
  */
 
 #define SOLIB_UNLOADED_LIBRARY_PATHNAME(pid) \
-(0)
+""
 
 /* This function returns TRUE if pc is the address of an instruction that
    lies within the dynamic linker (such as the event hook, or the dld


             reply	other threads:[~2003-12-11 13:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-11 13:45 Mark Kettenis [this message]
2003-12-12 21:53 ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200312111345.hBBDjIew000479@elgar.kettenis.dyndns.org \
    --to=kettenis@chello.nl \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox