From: Kevin Buettner <kevinb@redhat.com>
To: Mark Kettenis <kettenis@chello.nl>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH/RFC] Fix compilation warning in breakpoint.c
Date: Fri, 12 Dec 2003 21:53:00 -0000 [thread overview]
Message-ID: <1031212215307.ZM22454@localhost.localdomain> (raw)
In-Reply-To: Mark Kettenis <kettenis@chello.nl> "[PATCH/RFC] Fix compilation warning in breakpoint.c" (Dec 11, 2:45pm)
On Dec 11, 2:45pm, Mark Kettenis wrote:
> The newest GCC complains about us passing NULL as one of the arguments
> to strcmp(). This patch fixes the problem. It's similar to what we
> do for SOLIB_LOADED_LIBRARY_PATHNAME. I wonder whether is would be
> better to get rid of these definitions in solib.h altogether, and rely
> on the defaults in breakpoint.h. Thoughts?
I think it makes sense to remove the solib.h definitions that
breakpoint.h already provides defaults for. If you want to do this,
consider the solib.h changes to be preapproved.
Kevin
prev parent reply other threads:[~2003-12-12 21:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-11 13:45 Mark Kettenis
2003-12-12 21:53 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1031212215307.ZM22454@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@chello.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox