From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-29311-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 29294 invoked by alias); 12 Dec 2003 21:53:15 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 29287 invoked from network); 12 Dec 2003 21:53:15 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 12 Dec 2003 21:53:15 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hBCLrE214005
	for <gdb-patches@sources.redhat.com>; Fri, 12 Dec 2003 16:53:14 -0500
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hBCLrE221893;
	Fri, 12 Dec 2003 16:53:14 -0500
Received: from localhost.localdomain (vpn50-15.rdu.redhat.com [172.16.50.15])
	by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id hBCLrD6m022077;
	Fri, 12 Dec 2003 16:53:13 -0500
Received: (from kev@localhost)
	by localhost.localdomain (8.11.6/8.11.6) id hBCLr8G22455;
	Fri, 12 Dec 2003 14:53:08 -0700
Date: Fri, 12 Dec 2003 21:53:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
Message-Id: <1031212215307.ZM22454@localhost.localdomain>
In-Reply-To: Mark Kettenis <kettenis@chello.nl>
        "[PATCH/RFC] Fix compilation warning in breakpoint.c" (Dec 11,  2:45pm)
References: <200312111345.hBBDjIew000479@elgar.kettenis.dyndns.org>
To: Mark Kettenis <kettenis@chello.nl>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH/RFC] Fix compilation warning in breakpoint.c
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2003-12/txt/msg00340.txt.bz2

On Dec 11,  2:45pm, Mark Kettenis wrote:

> The newest GCC complains about us passing NULL as one of the arguments
> to strcmp().  This patch fixes the problem.  It's similar to what we
> do for SOLIB_LOADED_LIBRARY_PATHNAME.  I wonder whether is would be
> better to get rid of these definitions in solib.h altogether, and rely
> on the defaults in breakpoint.h.  Thoughts?

I think it makes sense to remove the solib.h definitions that
breakpoint.h already provides defaults for.  If you want to do this,
consider the solib.h changes to be preapproved.

Kevin