From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28382 invoked by alias); 11 Dec 2003 13:45:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28224 invoked from network); 11 Dec 2003 13:45:19 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144) by sources.redhat.com with SMTP; 11 Dec 2003 13:45:19 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id hBBDjI5l000260 for ; Thu, 11 Dec 2003 14:45:18 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id hBBDjIap000482 for ; Thu, 11 Dec 2003 14:45:18 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id hBBDjIew000479; Thu, 11 Dec 2003 14:45:18 +0100 (CET) Date: Thu, 11 Dec 2003 13:45:00 -0000 Message-Id: <200312111345.hBBDjIew000479@elgar.kettenis.dyndns.org> From: Mark Kettenis To: gdb-patches@sources.redhat.com Subject: [PATCH/RFC] Fix compilation warning in breakpoint.c X-SW-Source: 2003-12/txt/msg00314.txt.bz2 The newest GCC complains about us passing NULL as one of the arguments to strcmp(). This patch fixes the problem. It's similar to what we do for SOLIB_LOADED_LIBRARY_PATHNAME. I wonder whether is would be better to get rid of these definitions in solib.h altogether, and rely on the defaults in breakpoint.h. Thoughts? Meanwhile, I committed the attached as obvious. Mark Index: ChangeLog from Mark Kettenis * solib.h (SOLIB_UNLOADED_LIBRARY_PATHNAME): Define as "" instead of (0). Index: solib.h =================================================================== RCS file: /cvs/src/src/gdb/solib.h,v retrieving revision 1.10 diff -u -p -r1.10 solib.h --- solib.h 10 Jul 2003 21:56:25 -0000 1.10 +++ solib.h 11 Dec 2003 13:38:34 -0000 @@ -149,7 +149,7 @@ extern void solib_create_inferior_hook ( */ #define SOLIB_UNLOADED_LIBRARY_PATHNAME(pid) \ -(0) +"" /* This function returns TRUE if pc is the address of an instruction that lies within the dynamic linker (such as the event hook, or the dld