[RFA] Fix bug report #508

[RFA] Fix bug report #508

[Pierre Muller]

This is a fix (allmost obvious) to
the  bug report #508.


ChangeLog entry:

2002-04-25  Pierre Muller  <muller@ics.u-strasbg.fr>

	* symfile.c (add_filename_language): Fix wrong xrealloc size argument.


$ cvs diff -u -p -N symfile.c
Index: symfile.c
===================================================================
RCS file: /cvs/src/src/gdb/symfile.c,v
retrieving revision 1.59
diff -u -p -r1.59 symfile.c
--- symfile.c   22 Apr 2002 10:19:35 -0000      1.59
+++ symfile.c   24 Apr 2002 22:24:14 -0000
@@ -1831,8 +1831,9 @@ add_filename_language (char *ext, enum l
    if (fl_table_next >= fl_table_size)
      {
        fl_table_size += 10;
-      filename_language_table = xrealloc (filename_language_table,
-                                         fl_table_size);
+      filename_language_table =
+       xrealloc (filename_language_table,
+                 fl_table_size * sizeof (*filename_language_table));
      }

    filename_language_table[fl_table_next].ext = xstrdup (ext);



Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99

Re: [RFA] Fix bug report #508

[Daniel Jacobowitz]

On Thu, Apr 25, 2002 at 09:52:28AM +0200, Pierre Muller wrote:
> This is a fix (allmost obvious) to
> the  bug report #508.
> 
> 
> ChangeLog entry:
> 
> 2002-04-25  Pierre Muller  <muller@ics.u-strasbg.fr>
> 
> 	* symfile.c (add_filename_language): Fix wrong xrealloc size argument.

I'd call this obvious, actually.  Please commit it (but add 'Fix PR
gdb/508' above '* symfile.c' in your changelog).

> $ cvs diff -u -p -N symfile.c
> Index: symfile.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/symfile.c,v
> retrieving revision 1.59
> diff -u -p -r1.59 symfile.c
> --- symfile.c   22 Apr 2002 10:19:35 -0000      1.59
> +++ symfile.c   24 Apr 2002 22:24:14 -0000
> @@ -1831,8 +1831,9 @@ add_filename_language (char *ext, enum l
>     if (fl_table_next >= fl_table_size)
>       {
>         fl_table_size += 10;
> -      filename_language_table = xrealloc (filename_language_table,
> -                                         fl_table_size);
> +      filename_language_table =
> +       xrealloc (filename_language_table,
> +                 fl_table_size * sizeof (*filename_language_table));
>       }
> 
>     filename_language_table[fl_table_next].ext = xstrdup (ext);
> 
> 
> 
> Pierre Muller
> Institut Charles Sadron
> 6,rue Boussingault
> F 67083 STRASBOURG CEDEX (France)
> mailto:muller@ics.u-strasbg.fr
> Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99
> 

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

Re: [RFA] Fix bug report #508

[Pierre Muller]

At 18:04 25/04/2002 , Daniel Jacobowitz a écrit:
>On Thu, Apr 25, 2002 at 09:52:28AM +0200, Pierre Muller wrote:
> > This is a fix (allmost obvious) to
> > the  bug report #508.
> > 
> > 
> > ChangeLog entry:
> > 
> > 2002-04-25  Pierre Muller  <muller@ics.u-strasbg.fr>
> > 
> >       * symfile.c (add_filename_language): Fix wrong xrealloc size argument.
>
>I'd call this obvious, actually.  Please commit it (but add 'Fix PR
>gdb/508' above '* symfile.c' in your changelog).
Done.


Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99

Re: [RFA] Fix bug report #508

[Elena Zannoni]

Daniel Jacobowitz writes:
 > On Thu, Apr 25, 2002 at 09:52:28AM +0200, Pierre Muller wrote:
 > > This is a fix (allmost obvious) to
 > > the  bug report #508.
 > > 
 > > 
 > > ChangeLog entry:
 > > 
 > > 2002-04-25  Pierre Muller  <muller@ics.u-strasbg.fr>
 > > 
 > > 	* symfile.c (add_filename_language): Fix wrong xrealloc size argument.
 > 
 > I'd call this obvious, actually.  Please commit it (but add 'Fix PR
 > gdb/508' above '* symfile.c' in your changelog).

Thanks Daniel,
yes, please commit it.

Elena


 > 
 > > $ cvs diff -u -p -N symfile.c
 > > Index: symfile.c
 > > ===================================================================
 > > RCS file: /cvs/src/src/gdb/symfile.c,v
 > > retrieving revision 1.59
 > > diff -u -p -r1.59 symfile.c
 > > --- symfile.c   22 Apr 2002 10:19:35 -0000      1.59
 > > +++ symfile.c   24 Apr 2002 22:24:14 -0000
 > > @@ -1831,8 +1831,9 @@ add_filename_language (char *ext, enum l
 > >     if (fl_table_next >= fl_table_size)
 > >       {
 > >         fl_table_size += 10;
 > > -      filename_language_table = xrealloc (filename_language_table,
 > > -                                         fl_table_size);
 > > +      filename_language_table =
 > > +       xrealloc (filename_language_table,
 > > +                 fl_table_size * sizeof (*filename_language_table));
 > >       }
 > > 
 > >     filename_language_table[fl_table_next].ext = xstrdup (ext);
 > > 
 > > 
 > > 
 > > Pierre Muller
 > > Institut Charles Sadron
 > > 6,rue Boussingault
 > > F 67083 STRASBOURG CEDEX (France)
 > > mailto:muller@ics.u-strasbg.fr
 > > Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99
 > > 
 > 
 > -- 
 > Daniel Jacobowitz                           Carnegie Mellon University
 > MontaVista Software                         Debian GNU/Linux Developer

Re: [RFA] Fix bug report #508

[Pierre Muller]

At 18:41 25/04/2002 , Elena Zannoni a écrit:
>Daniel Jacobowitz writes:
>  > On Thu, Apr 25, 2002 at 09:52:28AM +0200, Pierre Muller wrote:
>  > > This is a fix (allmost obvious) to
>  > > the  bug report #508.
>  > > 
>  > > 
>  > > ChangeLog entry:
>  > > 
>  > > 2002-04-25  Pierre Muller  <muller@ics.u-strasbg.fr>
>  > > 
>  > >    * symfile.c (add_filename_language): Fix wrong xrealloc size argument.
>  > 
>  > I'd call this obvious, actually.  Please commit it (but add 'Fix PR
>  > gdb/508' above '* symfile.c' in your changelog).
>
>Thanks Daniel,
>yes, please commit it.

I already did, I hope I was not too fast here...

How do I change the status of the bug report?


Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99

Re: [RFA] Fix bug report #508

[Elena Zannoni]

Pierre Muller writes:
 > At 18:41 25/04/2002 , Elena Zannoni a écrit:
 > >Daniel Jacobowitz writes:
 > >  > On Thu, Apr 25, 2002 at 09:52:28AM +0200, Pierre Muller wrote:
 > >  > > This is a fix (allmost obvious) to
 > >  > > the  bug report #508.
 > >  > > 
 > >  > > 
 > >  > > ChangeLog entry:
 > >  > > 
 > >  > > 2002-04-25  Pierre Muller  <muller@ics.u-strasbg.fr>
 > >  > > 
 > >  > >    * symfile.c (add_filename_language): Fix wrong xrealloc size argument.
 > >  > 
 > >  > I'd call this obvious, actually.  Please commit it (but add 'Fix PR
 > >  > gdb/508' above '* symfile.c' in your changelog).
 > >
 > >Thanks Daniel,
 > >yes, please commit it.
 > 
 > I already did, I hope I was not too fast here...
 > 
 > How do I change the status of the bug report?
 > 


I usually log into gnats and change the state of the PR to closed.
http://sources.redhat.com/cgi-bin/gnatsweb.pl?database=gdb&user=guest&password=guest&cmd=query

(use the 'login again' button at the top to log in)

Elena



 > 
 > Pierre Muller
 > Institut Charles Sadron
 > 6,rue Boussingault
 > F 67083 STRASBOURG CEDEX (France)
 > mailto:muller@ics.u-strasbg.fr
 > Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99

Re: [RFA] Fix bug report #508

[David S. Miller]

   From: Daniel Jacobowitz <drow@mvista.com>
   Date: Thu, 25 Apr 2002 12:04:55 -0400

   On Thu, Apr 25, 2002 at 09:52:28AM +0200, Pierre Muller wrote:
   > 2002-04-25  Pierre Muller  <muller@ics.u-strasbg.fr>
   > 
   > 	* symfile.c (add_filename_language): Fix wrong xrealloc size argument.
   
   I'd call this obvious, actually.  Please commit it (but add 'Fix PR
   gdb/508' above '* symfile.c' in your changelog).

Wait... I was told that an alloca() length argument change
was anything but obvious.  How is this any different?

Re: [RFA] Fix bug report #508

[Daniel Jacobowitz]

On Thu, Apr 25, 2002 at 05:59:51PM -0700, David S. Miller wrote:
>    From: Daniel Jacobowitz <drow@mvista.com>
>    Date: Thu, 25 Apr 2002 12:04:55 -0400
> 
>    On Thu, Apr 25, 2002 at 09:52:28AM +0200, Pierre Muller wrote:
>    > 2002-04-25  Pierre Muller  <muller@ics.u-strasbg.fr>
>    > 
>    > 	* symfile.c (add_filename_language): Fix wrong xrealloc size argument.
>    
>    I'd call this obvious, actually.  Please commit it (but add 'Fix PR
>    gdb/508' above '* symfile.c' in your changelog).
> 
> Wait... I was told that an alloca() length argument change
> was anything but obvious.  How is this any different?

The code was reallocing with the number of elements in the array
instead of the size of the array.  That was obvious from my reading of
the patch alone, and made sense with respect to the PR filed yesterday
about this.  If that's not "obvious", I don't know what is.

I don't know what alloca length change you are talking about; I don't
read every message in that depth, although I try.  I have no context to
your complaint, so I can't respond to it.  I happened to read Pierre's,
and I happened to agree completely about his change, so I told him to
commit it under his own authority.  It's not as if I can approve the
bulk of the patches you've been posting!

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

Re: [RFA] Fix bug report #508

[David S. Miller]

   From: Daniel Jacobowitz <drow@mvista.com>
   Date: Thu, 25 Apr 2002 21:17:10 -0400

   On Thu, Apr 25, 2002 at 05:59:51PM -0700, David S. Miller wrote:
   > Wait... I was told that an alloca() length argument change
   > was anything but obvious.  How is this any different?
   
   The code was reallocing with the number of elements in the array
   instead of the size of the array.  That was obvious from my reading of
   the patch alone, and made sense with respect to the PR filed yesterday
   about this.  If that's not "obvious", I don't know what is.

Sorry, my comment wasn't directed at you personally, but rather was
meant to point out double standards on "what is obvious" in general
that occurs here.